Skip to content

Commit 4dd595c

Browse files
sohilmeharndb
authored andcommitted
syscalls: Remove file path comments from headers
Source file locations for syscall definitions can change over a period of time. File paths in comments get stale and are hard to maintain long term. Also, their usefulness is questionable since it would be easier to locate a syscall definition using the SYSCALL_DEFINEx() macro. Remove all source file path comments from the syscall headers. Also, equalize the uneven line spacing (some of which is introduced due to the deletions). Signed-off-by: Sohil Mehta <sohil.mehta@intel.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
1 parent 0526b56 commit 4dd595c

File tree

5 files changed

+85
-505
lines changed

5 files changed

+85
-505
lines changed

include/linux/compat.h

Lines changed: 9 additions & 73 deletions
Original file line numberDiff line numberDiff line change
@@ -581,11 +581,7 @@ asmlinkage long compat_sys_io_pgetevents_time64(compat_aio_context_t ctx_id,
581581
struct io_event __user *events,
582582
struct __kernel_timespec __user *timeout,
583583
const struct __compat_aio_sigset __user *usig);
584-
585-
/* fs/cookies.c */
586584
asmlinkage long compat_sys_lookup_dcookie(u32, u32, char __user *, compat_size_t);
587-
588-
/* fs/eventpoll.c */
589585
asmlinkage long compat_sys_epoll_pwait(int epfd,
590586
struct epoll_event __user *events,
591587
int maxevents, int timeout,
@@ -597,18 +593,12 @@ asmlinkage long compat_sys_epoll_pwait2(int epfd,
597593
const struct __kernel_timespec __user *timeout,
598594
const compat_sigset_t __user *sigmask,
599595
compat_size_t sigsetsize);
600-
601-
/* fs/fcntl.c */
602596
asmlinkage long compat_sys_fcntl(unsigned int fd, unsigned int cmd,
603597
compat_ulong_t arg);
604598
asmlinkage long compat_sys_fcntl64(unsigned int fd, unsigned int cmd,
605599
compat_ulong_t arg);
606-
607-
/* fs/ioctl.c */
608600
asmlinkage long compat_sys_ioctl(unsigned int fd, unsigned int cmd,
609601
compat_ulong_t arg);
610-
611-
/* fs/open.c */
612602
asmlinkage long compat_sys_statfs(const char __user *pathname,
613603
struct compat_statfs __user *buf);
614604
asmlinkage long compat_sys_statfs64(const char __user *pathname,
@@ -623,13 +613,9 @@ asmlinkage long compat_sys_ftruncate(unsigned int, compat_ulong_t);
623613
/* No generic prototype for truncate64, ftruncate64, fallocate */
624614
asmlinkage long compat_sys_openat(int dfd, const char __user *filename,
625615
int flags, umode_t mode);
626-
627-
/* fs/readdir.c */
628616
asmlinkage long compat_sys_getdents(unsigned int fd,
629617
struct compat_linux_dirent __user *dirent,
630618
unsigned int count);
631-
632-
/* fs/read_write.c */
633619
asmlinkage long compat_sys_lseek(unsigned int, compat_off_t, unsigned int);
634620
/* No generic prototype for pread64 and pwrite64 */
635621
asmlinkage ssize_t compat_sys_preadv(compat_ulong_t fd,
@@ -649,14 +635,10 @@ asmlinkage long compat_sys_pwritev64(unsigned long fd,
649635
const struct iovec __user *vec,
650636
unsigned long vlen, loff_t pos);
651637
#endif
652-
653-
/* fs/sendfile.c */
654638
asmlinkage long compat_sys_sendfile(int out_fd, int in_fd,
655639
compat_off_t __user *offset, compat_size_t count);
656640
asmlinkage long compat_sys_sendfile64(int out_fd, int in_fd,
657641
compat_loff_t __user *offset, compat_size_t count);
658-
659-
/* fs/select.c */
660642
asmlinkage long compat_sys_pselect6_time32(int n, compat_ulong_t __user *inp,
661643
compat_ulong_t __user *outp,
662644
compat_ulong_t __user *exp,
@@ -677,68 +659,45 @@ asmlinkage long compat_sys_ppoll_time64(struct pollfd __user *ufds,
677659
struct __kernel_timespec __user *tsp,
678660
const compat_sigset_t __user *sigmask,
679661
compat_size_t sigsetsize);
680-
681-
/* fs/signalfd.c */
682662
asmlinkage long compat_sys_signalfd4(int ufd,
683663
const compat_sigset_t __user *sigmask,
684664
compat_size_t sigsetsize, int flags);
685-
686-
/* fs/stat.c */
687665
asmlinkage long compat_sys_newfstatat(unsigned int dfd,
688666
const char __user *filename,
689667
struct compat_stat __user *statbuf,
690668
int flag);
691669
asmlinkage long compat_sys_newfstat(unsigned int fd,
692670
struct compat_stat __user *statbuf);
693-
694-
/* fs/sync.c: No generic prototype for sync_file_range and sync_file_range2 */
695-
696-
/* kernel/exit.c */
671+
/* No generic prototype for sync_file_range and sync_file_range2 */
697672
asmlinkage long compat_sys_waitid(int, compat_pid_t,
698673
struct compat_siginfo __user *, int,
699674
struct compat_rusage __user *);
700-
701-
702-
703-
/* kernel/futex.c */
704675
asmlinkage long
705676
compat_sys_set_robust_list(struct compat_robust_list_head __user *head,
706677
compat_size_t len);
707678
asmlinkage long
708679
compat_sys_get_robust_list(int pid, compat_uptr_t __user *head_ptr,
709680
compat_size_t __user *len_ptr);
710-
711-
/* kernel/itimer.c */
712681
asmlinkage long compat_sys_getitimer(int which,
713682
struct old_itimerval32 __user *it);
714683
asmlinkage long compat_sys_setitimer(int which,
715684
struct old_itimerval32 __user *in,
716685
struct old_itimerval32 __user *out);
717-
718-
/* kernel/kexec.c */
719686
asmlinkage long compat_sys_kexec_load(compat_ulong_t entry,
720687
compat_ulong_t nr_segments,
721688
struct compat_kexec_segment __user *,
722689
compat_ulong_t flags);
723-
724-
/* kernel/posix-timers.c */
725690
asmlinkage long compat_sys_timer_create(clockid_t which_clock,
726691
struct compat_sigevent __user *timer_event_spec,
727692
timer_t __user *created_timer_id);
728-
729-
/* kernel/ptrace.c */
730693
asmlinkage long compat_sys_ptrace(compat_long_t request, compat_long_t pid,
731694
compat_long_t addr, compat_long_t data);
732-
733-
/* kernel/sched/core.c */
734695
asmlinkage long compat_sys_sched_setaffinity(compat_pid_t pid,
735696
unsigned int len,
736697
compat_ulong_t __user *user_mask_ptr);
737698
asmlinkage long compat_sys_sched_getaffinity(compat_pid_t pid,
738699
unsigned int len,
739700
compat_ulong_t __user *user_mask_ptr);
740-
741-
/* kernel/signal.c */
742701
asmlinkage long compat_sys_sigaltstack(const compat_stack_t __user *uss_ptr,
743702
compat_stack_t __user *uoss_ptr);
744703
asmlinkage long compat_sys_rt_sigsuspend(compat_sigset_t __user *unewset,
@@ -763,25 +722,17 @@ asmlinkage long compat_sys_rt_sigtimedwait_time64(compat_sigset_t __user *uthese
763722
asmlinkage long compat_sys_rt_sigqueueinfo(compat_pid_t pid, int sig,
764723
struct compat_siginfo __user *uinfo);
765724
/* No generic prototype for rt_sigreturn */
766-
767-
/* kernel/sys.c */
768725
asmlinkage long compat_sys_times(struct compat_tms __user *tbuf);
769726
asmlinkage long compat_sys_getrlimit(unsigned int resource,
770727
struct compat_rlimit __user *rlim);
771728
asmlinkage long compat_sys_setrlimit(unsigned int resource,
772729
struct compat_rlimit __user *rlim);
773730
asmlinkage long compat_sys_getrusage(int who, struct compat_rusage __user *ru);
774-
775-
/* kernel/time.c */
776731
asmlinkage long compat_sys_gettimeofday(struct old_timeval32 __user *tv,
777732
struct timezone __user *tz);
778733
asmlinkage long compat_sys_settimeofday(struct old_timeval32 __user *tv,
779734
struct timezone __user *tz);
780-
781-
/* kernel/timer.c */
782735
asmlinkage long compat_sys_sysinfo(struct compat_sysinfo __user *info);
783-
784-
/* ipc/mqueue.c */
785736
asmlinkage long compat_sys_mq_open(const char __user *u_name,
786737
int oflag, compat_mode_t mode,
787738
struct compat_mq_attr __user *u_attr);
@@ -790,43 +741,28 @@ asmlinkage long compat_sys_mq_notify(mqd_t mqdes,
790741
asmlinkage long compat_sys_mq_getsetattr(mqd_t mqdes,
791742
const struct compat_mq_attr __user *u_mqstat,
792743
struct compat_mq_attr __user *u_omqstat);
793-
794-
/* ipc/msg.c */
795744
asmlinkage long compat_sys_msgctl(int first, int second, void __user *uptr);
796745
asmlinkage long compat_sys_msgrcv(int msqid, compat_uptr_t msgp,
797746
compat_ssize_t msgsz, compat_long_t msgtyp, int msgflg);
798747
asmlinkage long compat_sys_msgsnd(int msqid, compat_uptr_t msgp,
799748
compat_ssize_t msgsz, int msgflg);
800-
801-
/* ipc/sem.c */
802749
asmlinkage long compat_sys_semctl(int semid, int semnum, int cmd, int arg);
803-
804-
/* ipc/shm.c */
805750
asmlinkage long compat_sys_shmctl(int first, int second, void __user *uptr);
806751
asmlinkage long compat_sys_shmat(int shmid, compat_uptr_t shmaddr, int shmflg);
807-
808-
/* net/socket.c */
809752
asmlinkage long compat_sys_recvfrom(int fd, void __user *buf, compat_size_t len,
810753
unsigned flags, struct sockaddr __user *addr,
811754
int __user *addrlen);
812755
asmlinkage long compat_sys_sendmsg(int fd, struct compat_msghdr __user *msg,
813756
unsigned flags);
814757
asmlinkage long compat_sys_recvmsg(int fd, struct compat_msghdr __user *msg,
815758
unsigned int flags);
816-
817-
/* mm/filemap.c: No generic prototype for readahead */
818-
819-
/* security/keys/keyctl.c */
759+
/* No generic prototype for readahead */
820760
asmlinkage long compat_sys_keyctl(u32 option,
821761
u32 arg2, u32 arg3, u32 arg4, u32 arg5);
822-
823-
/* arch/example/kernel/sys_example.c */
824762
asmlinkage long compat_sys_execve(const char __user *filename, const compat_uptr_t __user *argv,
825763
const compat_uptr_t __user *envp);
826-
827-
/* mm/fadvise.c: No generic prototype for fadvise64_64 */
828-
829-
/* mm/, CONFIG_MMU only */
764+
/* No generic prototype for fadvise64_64 */
765+
/* CONFIG_MMU only */
830766
asmlinkage long compat_sys_rt_tgsigqueueinfo(compat_pid_t tgid,
831767
compat_pid_t pid, int sig,
832768
struct compat_siginfo __user *uinfo);
@@ -896,18 +832,18 @@ asmlinkage long compat_sys_ustat(unsigned dev, struct compat_ustat __user *u32);
896832
asmlinkage long compat_sys_recv(int fd, void __user *buf, compat_size_t len,
897833
unsigned flags);
898834

899-
/* obsolete: fs/readdir.c */
835+
/* obsolete */
900836
asmlinkage long compat_sys_old_readdir(unsigned int fd,
901837
struct compat_old_linux_dirent __user *,
902838
unsigned int count);
903839

904-
/* obsolete: fs/select.c */
840+
/* obsolete */
905841
asmlinkage long compat_sys_old_select(struct compat_sel_arg_struct __user *arg);
906842

907-
/* obsolete: ipc */
843+
/* obsolete */
908844
asmlinkage long compat_sys_ipc(u32, int, int, u32, compat_uptr_t, u32);
909845

910-
/* obsolete: kernel/signal.c */
846+
/* obsolete */
911847
#ifdef __ARCH_WANT_SYS_SIGPENDING
912848
asmlinkage long compat_sys_sigpending(compat_old_sigset_t __user *set);
913849
#endif
@@ -922,7 +858,7 @@ asmlinkage long compat_sys_sigaction(int sig,
922858
struct compat_old_sigaction __user *oact);
923859
#endif
924860

925-
/* obsolete: net/socket.c */
861+
/* obsolete */
926862
asmlinkage long compat_sys_socketcall(int call, u32 __user *args);
927863

928864
#ifdef __ARCH_WANT_COMPAT_TRUNCATE64

0 commit comments

Comments
 (0)