Skip to content

Commit 4dc00af

Browse files
krzkrafaeljw
authored andcommitted
thermal: qcom-spmi-adc-tm5: Simplify with scoped for each OF child loop
Use scoped for_each_available_child_of_node_scoped() when iterating over device nodes to make code a bit simpler. Reviewed-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Link: https://patch.msgid.link/20241010-b4-cleanup-h-of-node-put-thermal-v4-4-bfbe29ad81f4@linaro.org Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 8309135 commit 4dc00af

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

drivers/thermal/qcom/qcom-spmi-adc-tm5.c

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,6 @@ static const struct adc_tm5_data adc_tm5_gen2_data_pmic = {
938938
static int adc_tm5_get_dt_data(struct adc_tm5_chip *adc_tm, struct device_node *node)
939939
{
940940
struct adc_tm5_channel *channels;
941-
struct device_node *child;
942941
u32 value;
943942
int ret;
944943
struct device *dev = adc_tm->dev;
@@ -982,12 +981,10 @@ static int adc_tm5_get_dt_data(struct adc_tm5_chip *adc_tm, struct device_node *
982981
adc_tm->avg_samples = VADC_DEF_AVG_SAMPLES;
983982
}
984983

985-
for_each_available_child_of_node(node, child) {
984+
for_each_available_child_of_node_scoped(node, child) {
986985
ret = adc_tm5_get_dt_channel_data(adc_tm, channels, child);
987-
if (ret) {
988-
of_node_put(child);
986+
if (ret)
989987
return ret;
990-
}
991988

992989
channels++;
993990
}

0 commit comments

Comments
 (0)