Skip to content

Commit 4da3c71

Browse files
committed
erofs: drop unnecessary WARN_ON() in erofs_kill_sb()
Previously, .kill_sb() will be called only after fill_super fails. It will be changed [1]. Besides, checking for s_magic in erofs_kill_sb() is unnecessary from any point of view. Let's get rid of it now. [1] https://lore.kernel.org/r/20230731-flugbereit-wohnlage-78acdf95ab7e@brauner Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Acked-by: Christian Brauner <brauner@kernel.org> Link: https://lore.kernel.org/r/20230801014737.28614-1-hsiangkao@linux.alibaba.com
1 parent 94c43de commit 4da3c71

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

fs/erofs/super.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -889,8 +889,6 @@ static void erofs_kill_sb(struct super_block *sb)
889889
{
890890
struct erofs_sb_info *sbi;
891891

892-
WARN_ON(sb->s_magic != EROFS_SUPER_MAGIC);
893-
894892
/* pseudo mount for anon inodes */
895893
if (sb->s_flags & SB_KERNMOUNT) {
896894
kill_anon_super(sb);

0 commit comments

Comments
 (0)