Skip to content

Commit 4d266c2

Browse files
Neeraj Upadhyaypaulmckrcu
authored andcommitted
rcu/exp: Fix check for idle context in rcu_exp_handler
For PREEMPT_RCU, the rcu_exp_handler() function checks whether the current CPU is in idle, by calling rcu_dynticks_curr_cpu_in_eqs(). However, rcu_exp_handler() is called in IPI handler context. So, it should be checking the idle context using rcu_is_cpu_rrupt_from_idle(). Fix this by using rcu_is_cpu_rrupt_from_idle() instead of rcu_dynticks_curr_cpu_in_eqs(). Non-preempt configuration already uses the correct check. Reviewed-by: Frederic Weisbecker <frederic@kernel.org> Signed-off-by: Neeraj Upadhyay <quic_neeraju@quicinc.com> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
1 parent da12301 commit 4d266c2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/rcu/tree_exp.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -656,7 +656,7 @@ static void rcu_exp_handler(void *unused)
656656
*/
657657
if (!depth) {
658658
if (!(preempt_count() & (PREEMPT_MASK | SOFTIRQ_MASK)) ||
659-
rcu_dynticks_curr_cpu_in_eqs()) {
659+
rcu_is_cpu_rrupt_from_idle()) {
660660
rcu_report_exp_rdp(rdp);
661661
} else {
662662
WRITE_ONCE(rdp->cpu_no_qs.b.exp, true);

0 commit comments

Comments
 (0)