Skip to content

Commit 4c66a32

Browse files
Christoph Hellwigaxboe
authored andcommitted
Revert "block: freeze the queue earlier in del_gendisk"
This reverts commit a09b314. Dusty Mabe reported consistent hang during CoreOS shutdown with a MD RAID1 setup. Although apparently similar hangs happened before, and this patch most likely is not the root cause it made it much more severe. Revert it until we can figure out what is going on with the md driver. Signed-off-by: Christoph Hellwig <hch@lst.de> Link: https://lore.kernel.org/r/20220919144049.978907-1-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent db7ba07 commit 4c66a32

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

block/genhd.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -602,7 +602,6 @@ void del_gendisk(struct gendisk *disk)
602602
* Prevent new I/O from crossing bio_queue_enter().
603603
*/
604604
blk_queue_start_drain(q);
605-
blk_mq_freeze_queue_wait(q);
606605

607606
if (!(disk->flags & GENHD_FL_HIDDEN)) {
608607
sysfs_remove_link(&disk_to_dev(disk)->kobj, "bdi");
@@ -626,6 +625,8 @@ void del_gendisk(struct gendisk *disk)
626625
pm_runtime_set_memalloc_noio(disk_to_dev(disk), false);
627626
device_del(disk_to_dev(disk));
628627

628+
blk_mq_freeze_queue_wait(q);
629+
629630
blk_throtl_cancel_bios(disk->queue);
630631

631632
blk_sync_queue(q);

0 commit comments

Comments
 (0)