Skip to content

Commit 4c2fdf7

Browse files
Liao Changrafaeljw
authored andcommitted
cpufreq: pcc: Fix the potentinal scheduling delays in target_index()
pcc_cpufreq_target(): cpufreq_freq_transition_begin(); spin_lock(&pcc_lock); [critical section] cpufreq_freq_transition_end(); spin_unlock(&pcc_lock); Above code has a performance issue, consider that Task0 executes 'cpufreq_freq_transition_end()' to wake Task1 and preempted imediatedly without releasing 'pcc_lock', then Task1 needs to wait for Task0 to release 'pcc_lock'. In the worst case, this locking order can result in Task1 wasting two scheduling rounds before it can enter the critical section. Signed-off-by: Liao Chang <liaochang1@huawei.com> Acked-by: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 916f138 commit 4c2fdf7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/cpufreq/pcc-cpufreq.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -232,8 +232,8 @@ static int pcc_cpufreq_target(struct cpufreq_policy *policy,
232232
status = ioread16(&pcch_hdr->status);
233233
iowrite16(0, &pcch_hdr->status);
234234

235-
cpufreq_freq_transition_end(policy, &freqs, status != CMD_COMPLETE);
236235
spin_unlock(&pcc_lock);
236+
cpufreq_freq_transition_end(policy, &freqs, status != CMD_COMPLETE);
237237

238238
if (status != CMD_COMPLETE) {
239239
pr_debug("target: FAILED for cpu %d, with status: 0x%x\n",

0 commit comments

Comments
 (0)