Skip to content

Commit 4b22f19

Browse files
rodrigovivilucasdemarchi
authored andcommitted
drm/xe/guc_pc: Remove duplicated pc_start call
xe_guc_pc_start() was getting called from both xe_uc_init_hw() and from xe_guc_start(). But both are called from do_gt_restart() and only xe_uc_init_hw() is called at initialization. So, let's remove the duplication in the regular gt_restart path. The only place where xe_guc_pc_start() won't get called now is on the gt_reset failure path. However, if gt_reset has failed, it is really unlikely that the PC start will work or is desired. Cc: Vinay Belgaumkar <vinay.belgaumkar@intel.com> Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com> Reviewed-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250306220643.1014049-1-rodrigo.vivi@intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com> (cherry picked from commit fc858dd) Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
1 parent 626fb11 commit 4b22f19

File tree

1 file changed

+0
-8
lines changed

1 file changed

+0
-8
lines changed

drivers/gpu/drm/xe/xe_guc.c

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1496,14 +1496,6 @@ void xe_guc_stop(struct xe_guc *guc)
14961496

14971497
int xe_guc_start(struct xe_guc *guc)
14981498
{
1499-
if (!IS_SRIOV_VF(guc_to_xe(guc))) {
1500-
int err;
1501-
1502-
err = xe_guc_pc_start(&guc->pc);
1503-
xe_gt_WARN(guc_to_gt(guc), err, "Failed to start GuC PC: %pe\n",
1504-
ERR_PTR(err));
1505-
}
1506-
15071499
return xe_guc_submit_start(guc);
15081500
}
15091501

0 commit comments

Comments
 (0)