Skip to content

Commit 4866b2b

Browse files
q2vendavem330
authored andcommitted
tcp: Fix a data-race around sysctl_tcp_comp_sack_delay_ns.
While reading sysctl_tcp_comp_sack_delay_ns, it can be changed concurrently. Thus, we need to add READ_ONCE() to its reader. Fixes: 6d82aa2 ("tcp: add tcp_comp_sack_delay_ns sysctl") Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 0273954 commit 4866b2b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

net/ipv4/tcp_input.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5542,7 +5542,8 @@ static void __tcp_ack_snd_check(struct sock *sk, int ofo_possible)
55425542
if (tp->srtt_us && tp->srtt_us < rtt)
55435543
rtt = tp->srtt_us;
55445544

5545-
delay = min_t(unsigned long, sock_net(sk)->ipv4.sysctl_tcp_comp_sack_delay_ns,
5545+
delay = min_t(unsigned long,
5546+
READ_ONCE(sock_net(sk)->ipv4.sysctl_tcp_comp_sack_delay_ns),
55465547
rtt * (NSEC_PER_USEC >> 3)/20);
55475548
sock_hold(sk);
55485549
hrtimer_start_range_ns(&tp->compressed_ack_timer, ns_to_ktime(delay),

0 commit comments

Comments
 (0)