Skip to content

Commit 47bd37f

Browse files
committed
drm/msm/adreno: Move adreno info to config
Let's just stash it in adreno_platform_config rather than looking it up in N different places. Signed-off-by: Rob Clark <robdclark@chromium.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/549777/
1 parent 8825f59 commit 47bd37f

File tree

4 files changed

+8
-17
lines changed

4 files changed

+8
-17
lines changed

drivers/gpu/drm/msm/adreno/a6xx_gpu.c

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2316,7 +2316,6 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
23162316
struct msm_drm_private *priv = dev->dev_private;
23172317
struct platform_device *pdev = priv->gpu_pdev;
23182318
struct adreno_platform_config *config = pdev->dev.platform_data;
2319-
const struct adreno_info *info;
23202319
struct device_node *node;
23212320
struct a6xx_gpu *a6xx_gpu;
23222321
struct adreno_gpu *adreno_gpu;
@@ -2341,20 +2340,12 @@ struct msm_gpu *a6xx_gpu_init(struct drm_device *dev)
23412340

23422341
adreno_gpu->gmu_is_wrapper = of_device_is_compatible(node, "qcom,adreno-gmu-wrapper");
23432342

2344-
/*
2345-
* We need to know the platform type before calling into adreno_gpu_init
2346-
* so that the hw_apriv flag can be correctly set. Snoop into the info
2347-
* and grab the revision number
2348-
*/
2349-
info = adreno_info(config->rev);
2350-
if (!info)
2351-
return ERR_PTR(-EINVAL);
2352-
2353-
adreno_gpu->base.hw_apriv = !!(info->quirks & ADRENO_QUIRK_HAS_HW_APRIV);
2343+
adreno_gpu->base.hw_apriv =
2344+
!!(config->info->quirks & ADRENO_QUIRK_HAS_HW_APRIV);
23542345

23552346
a6xx_llc_slices_init(pdev, a6xx_gpu);
23562347

2357-
ret = a6xx_set_supported_hw(&pdev->dev, info);
2348+
ret = a6xx_set_supported_hw(&pdev->dev, config->info);
23582349
if (ret) {
23592350
a6xx_destroy(&(a6xx_gpu->base.base));
23602351
return ERR_PTR(ret);

drivers/gpu/drm/msm/adreno/adreno_device.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -508,7 +508,7 @@ bool adreno_cmp_rev(struct adreno_rev rev1, struct adreno_rev rev2)
508508
_rev_match(rev1.patchid, rev2.patchid);
509509
}
510510

511-
const struct adreno_info *adreno_info(struct adreno_rev rev)
511+
static const struct adreno_info *adreno_info(struct adreno_rev rev)
512512
{
513513
int i;
514514

@@ -659,13 +659,14 @@ static int adreno_bind(struct device *dev, struct device *master, void *data)
659659
priv->gpu_pdev = to_platform_device(dev);
660660

661661
info = adreno_info(config.rev);
662-
663662
if (!info) {
664663
dev_warn(drm->dev, "Unknown GPU revision: %"ADRENO_CHIPID_FMT"\n",
665664
ADRENO_CHIPID_ARGS(config.rev));
666665
return -ENXIO;
667666
}
668667

668+
config.info = info;
669+
669670
DBG("Found GPU: %"ADRENO_CHIPID_FMT, ADRENO_CHIPID_ARGS(config.rev));
670671

671672
priv->is_a2xx = info->family < ADRENO_3XX;

drivers/gpu/drm/msm/adreno/adreno_gpu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1079,7 +1079,7 @@ int adreno_gpu_init(struct drm_device *drm, struct platform_device *pdev,
10791079
int ret;
10801080

10811081
adreno_gpu->funcs = funcs;
1082-
adreno_gpu->info = adreno_info(config->rev);
1082+
adreno_gpu->info = config->info;
10831083
adreno_gpu->rev = *rev;
10841084

10851085
/* Only handle the core clock when GMU is not in use (or is absent). */

drivers/gpu/drm/msm/adreno/adreno_gpu.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -130,8 +130,6 @@ struct adreno_info {
130130
*/
131131
#define ADRENO_SPEEDBINS(tbl...) (struct adreno_speedbin[]) { tbl {SHRT_MAX, 0} }
132132

133-
const struct adreno_info *adreno_info(struct adreno_rev rev);
134-
135133
struct adreno_gpu {
136134
struct msm_gpu base;
137135
struct adreno_rev rev;
@@ -185,6 +183,7 @@ struct adreno_ocmem {
185183
/* platform config data (ie. from DT, or pdata) */
186184
struct adreno_platform_config {
187185
struct adreno_rev rev;
186+
const struct adreno_info *info;
188187
};
189188

190189
#define ADRENO_IDLE_TIMEOUT msecs_to_jiffies(1000)

0 commit comments

Comments
 (0)