Skip to content

Commit 475918e

Browse files
shavitmichaelwilldeacon
authored andcommitted
iommu/arm-smmu-v3: Rename cdcfg to cd_table
cdcfg is a confusing name, especially given other variables with the cfg suffix in this driver. cd_table more clearly describes what is being operated on. Tested-by: Nicolin Chen <nicolinc@nvidia.com> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com> Reviewed-by: Nicolin Chen <nicolinc@nvidia.com> Signed-off-by: Michael Shavit <mshavit@google.com> Link: https://lore.kernel.org/r/20230915211705.v8.9.I5ee79793b444ddb933e8bc1eb7b77e728d7f8350@changeid Signed-off-by: Will Deacon <will@kernel.org>
1 parent 6032f58 commit 475918e

File tree

1 file changed

+35
-35
lines changed

1 file changed

+35
-35
lines changed

drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -1025,18 +1025,18 @@ static __le64 *arm_smmu_get_cd_ptr(struct arm_smmu_master *master, u32 ssid)
10251025
unsigned int idx;
10261026
struct arm_smmu_l1_ctx_desc *l1_desc;
10271027
struct arm_smmu_device *smmu = master->smmu;
1028-
struct arm_smmu_ctx_desc_cfg *cdcfg = &master->cd_table;
1028+
struct arm_smmu_ctx_desc_cfg *cd_table = &master->cd_table;
10291029

1030-
if (cdcfg->s1fmt == STRTAB_STE_0_S1FMT_LINEAR)
1031-
return cdcfg->cdtab + ssid * CTXDESC_CD_DWORDS;
1030+
if (cd_table->s1fmt == STRTAB_STE_0_S1FMT_LINEAR)
1031+
return cd_table->cdtab + ssid * CTXDESC_CD_DWORDS;
10321032

10331033
idx = ssid >> CTXDESC_SPLIT;
1034-
l1_desc = &cdcfg->l1_desc[idx];
1034+
l1_desc = &cd_table->l1_desc[idx];
10351035
if (!l1_desc->l2ptr) {
10361036
if (arm_smmu_alloc_cd_leaf_table(smmu, l1_desc))
10371037
return NULL;
10381038

1039-
l1ptr = cdcfg->cdtab + idx * CTXDESC_L1_DESC_DWORDS;
1039+
l1ptr = cd_table->cdtab + idx * CTXDESC_L1_DESC_DWORDS;
10401040
arm_smmu_write_cd_l1_desc(l1ptr, l1_desc);
10411041
/* An invalid L1CD can be cached */
10421042
arm_smmu_sync_cd(master, ssid, false);
@@ -1131,35 +1131,35 @@ static int arm_smmu_alloc_cd_tables(struct arm_smmu_master *master)
11311131
size_t l1size;
11321132
size_t max_contexts;
11331133
struct arm_smmu_device *smmu = master->smmu;
1134-
struct arm_smmu_ctx_desc_cfg *cdcfg = &master->cd_table;
1134+
struct arm_smmu_ctx_desc_cfg *cd_table = &master->cd_table;
11351135

1136-
cdcfg->stall_enabled = master->stall_enabled;
1137-
cdcfg->s1cdmax = master->ssid_bits;
1138-
max_contexts = 1 << cdcfg->s1cdmax;
1136+
cd_table->stall_enabled = master->stall_enabled;
1137+
cd_table->s1cdmax = master->ssid_bits;
1138+
max_contexts = 1 << cd_table->s1cdmax;
11391139

11401140
if (!(smmu->features & ARM_SMMU_FEAT_2_LVL_CDTAB) ||
11411141
max_contexts <= CTXDESC_L2_ENTRIES) {
1142-
cdcfg->s1fmt = STRTAB_STE_0_S1FMT_LINEAR;
1143-
cdcfg->num_l1_ents = max_contexts;
1142+
cd_table->s1fmt = STRTAB_STE_0_S1FMT_LINEAR;
1143+
cd_table->num_l1_ents = max_contexts;
11441144

11451145
l1size = max_contexts * (CTXDESC_CD_DWORDS << 3);
11461146
} else {
1147-
cdcfg->s1fmt = STRTAB_STE_0_S1FMT_64K_L2;
1148-
cdcfg->num_l1_ents = DIV_ROUND_UP(max_contexts,
1147+
cd_table->s1fmt = STRTAB_STE_0_S1FMT_64K_L2;
1148+
cd_table->num_l1_ents = DIV_ROUND_UP(max_contexts,
11491149
CTXDESC_L2_ENTRIES);
11501150

1151-
cdcfg->l1_desc = devm_kcalloc(smmu->dev, cdcfg->num_l1_ents,
1152-
sizeof(*cdcfg->l1_desc),
1151+
cd_table->l1_desc = devm_kcalloc(smmu->dev, cd_table->num_l1_ents,
1152+
sizeof(*cd_table->l1_desc),
11531153
GFP_KERNEL);
1154-
if (!cdcfg->l1_desc)
1154+
if (!cd_table->l1_desc)
11551155
return -ENOMEM;
11561156

1157-
l1size = cdcfg->num_l1_ents * (CTXDESC_L1_DESC_DWORDS << 3);
1157+
l1size = cd_table->num_l1_ents * (CTXDESC_L1_DESC_DWORDS << 3);
11581158
}
11591159

1160-
cdcfg->cdtab = dmam_alloc_coherent(smmu->dev, l1size, &cdcfg->cdtab_dma,
1160+
cd_table->cdtab = dmam_alloc_coherent(smmu->dev, l1size, &cd_table->cdtab_dma,
11611161
GFP_KERNEL);
1162-
if (!cdcfg->cdtab) {
1162+
if (!cd_table->cdtab) {
11631163
dev_warn(smmu->dev, "failed to allocate context descriptor\n");
11641164
ret = -ENOMEM;
11651165
goto err_free_l1;
@@ -1168,9 +1168,9 @@ static int arm_smmu_alloc_cd_tables(struct arm_smmu_master *master)
11681168
return 0;
11691169

11701170
err_free_l1:
1171-
if (cdcfg->l1_desc) {
1172-
devm_kfree(smmu->dev, cdcfg->l1_desc);
1173-
cdcfg->l1_desc = NULL;
1171+
if (cd_table->l1_desc) {
1172+
devm_kfree(smmu->dev, cd_table->l1_desc);
1173+
cd_table->l1_desc = NULL;
11741174
}
11751175
return ret;
11761176
}
@@ -1180,30 +1180,30 @@ static void arm_smmu_free_cd_tables(struct arm_smmu_master *master)
11801180
int i;
11811181
size_t size, l1size;
11821182
struct arm_smmu_device *smmu = master->smmu;
1183-
struct arm_smmu_ctx_desc_cfg *cdcfg = &master->cd_table;
1183+
struct arm_smmu_ctx_desc_cfg *cd_table = &master->cd_table;
11841184

1185-
if (cdcfg->l1_desc) {
1185+
if (cd_table->l1_desc) {
11861186
size = CTXDESC_L2_ENTRIES * (CTXDESC_CD_DWORDS << 3);
11871187

1188-
for (i = 0; i < cdcfg->num_l1_ents; i++) {
1189-
if (!cdcfg->l1_desc[i].l2ptr)
1188+
for (i = 0; i < cd_table->num_l1_ents; i++) {
1189+
if (!cd_table->l1_desc[i].l2ptr)
11901190
continue;
11911191

11921192
dmam_free_coherent(smmu->dev, size,
1193-
cdcfg->l1_desc[i].l2ptr,
1194-
cdcfg->l1_desc[i].l2ptr_dma);
1193+
cd_table->l1_desc[i].l2ptr,
1194+
cd_table->l1_desc[i].l2ptr_dma);
11951195
}
1196-
devm_kfree(smmu->dev, cdcfg->l1_desc);
1197-
cdcfg->l1_desc = NULL;
1196+
devm_kfree(smmu->dev, cd_table->l1_desc);
1197+
cd_table->l1_desc = NULL;
11981198

1199-
l1size = cdcfg->num_l1_ents * (CTXDESC_L1_DESC_DWORDS << 3);
1199+
l1size = cd_table->num_l1_ents * (CTXDESC_L1_DESC_DWORDS << 3);
12001200
} else {
1201-
l1size = cdcfg->num_l1_ents * (CTXDESC_CD_DWORDS << 3);
1201+
l1size = cd_table->num_l1_ents * (CTXDESC_CD_DWORDS << 3);
12021202
}
12031203

1204-
dmam_free_coherent(smmu->dev, l1size, cdcfg->cdtab, cdcfg->cdtab_dma);
1205-
cdcfg->cdtab_dma = 0;
1206-
cdcfg->cdtab = NULL;
1204+
dmam_free_coherent(smmu->dev, l1size, cd_table->cdtab, cd_table->cdtab_dma);
1205+
cd_table->cdtab_dma = 0;
1206+
cd_table->cdtab = NULL;
12071207
}
12081208

12091209
bool arm_smmu_free_asid(struct arm_smmu_ctx_desc *cd)

0 commit comments

Comments
 (0)