Skip to content

Commit 44eae52

Browse files
qzhuo2aegl
authored andcommitted
EDAC/ie31200: Fix the 3rd parameter name of *populate_dimm_info()
The 3rd parameter of *populate_dimm_info() pertains to the DIMM index within a channel, not the channel index. Fix the parameter name to dimm to reflect its actual purpose. No functional changes intended. Signed-off-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com> Signed-off-by: Tony Luck <tony.luck@intel.com> Tested-by: Gary Wang <gary.c.wang@intel.com> Link: https://lore.kernel.org/r/20250310011411.31685-5-qiuxu.zhuo@intel.com
1 parent 231e341 commit 44eae52

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

drivers/edac/ie31200_edac.c

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -377,29 +377,29 @@ static void __iomem *ie31200_map_mchbar(struct pci_dev *pdev)
377377
}
378378

379379
static void __skl_populate_dimm_info(struct dimm_data *dd, u32 addr_decode,
380-
int chan)
380+
int dimm)
381381
{
382-
dd->size = (addr_decode >> (chan << 4)) & IE31200_MAD_DIMM_SIZE_SKL;
383-
dd->dual_rank = (addr_decode & (IE31200_MAD_DIMM_A_RANK_SKL << (chan << 4))) ? 1 : 0;
384-
dd->x16_width = ((addr_decode & (IE31200_MAD_DIMM_A_WIDTH_SKL << (chan << 4))) >>
385-
(IE31200_MAD_DIMM_A_WIDTH_SKL_SHIFT + (chan << 4)));
382+
dd->size = (addr_decode >> (dimm << 4)) & IE31200_MAD_DIMM_SIZE_SKL;
383+
dd->dual_rank = (addr_decode & (IE31200_MAD_DIMM_A_RANK_SKL << (dimm << 4))) ? 1 : 0;
384+
dd->x16_width = ((addr_decode & (IE31200_MAD_DIMM_A_WIDTH_SKL << (dimm << 4))) >>
385+
(IE31200_MAD_DIMM_A_WIDTH_SKL_SHIFT + (dimm << 4)));
386386
}
387387

388388
static void __populate_dimm_info(struct dimm_data *dd, u32 addr_decode,
389-
int chan)
389+
int dimm)
390390
{
391-
dd->size = (addr_decode >> (chan << 3)) & IE31200_MAD_DIMM_SIZE;
392-
dd->dual_rank = (addr_decode & (IE31200_MAD_DIMM_A_RANK << chan)) ? 1 : 0;
393-
dd->x16_width = (addr_decode & (IE31200_MAD_DIMM_A_WIDTH << chan)) ? 1 : 0;
391+
dd->size = (addr_decode >> (dimm << 3)) & IE31200_MAD_DIMM_SIZE;
392+
dd->dual_rank = (addr_decode & (IE31200_MAD_DIMM_A_RANK << dimm)) ? 1 : 0;
393+
dd->x16_width = (addr_decode & (IE31200_MAD_DIMM_A_WIDTH << dimm)) ? 1 : 0;
394394
}
395395

396-
static void populate_dimm_info(struct dimm_data *dd, u32 addr_decode, int chan,
396+
static void populate_dimm_info(struct dimm_data *dd, u32 addr_decode, int dimm,
397397
bool skl)
398398
{
399399
if (skl)
400-
__skl_populate_dimm_info(dd, addr_decode, chan);
400+
__skl_populate_dimm_info(dd, addr_decode, dimm);
401401
else
402-
__populate_dimm_info(dd, addr_decode, chan);
402+
__populate_dimm_info(dd, addr_decode, dimm);
403403
}
404404

405405

0 commit comments

Comments
 (0)