Skip to content

Commit 443d61d

Browse files
u1f383Steve French
authored andcommitted
ksmbd: allocate one more byte for implied bcc[0]
ksmbd_smb2_check_message allows client to return one byte more, so we need to allocate additional memory in ksmbd_conn_handler_loop to avoid out-of-bound access. Cc: stable@vger.kernel.org Signed-off-by: Chih-Yen Chang <cc85nod@gmail.com> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent f0a96d1 commit 443d61d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

fs/ksmbd/connection.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -351,7 +351,8 @@ int ksmbd_conn_handler_loop(void *p)
351351
break;
352352

353353
/* 4 for rfc1002 length field */
354-
size = pdu_size + 4;
354+
/* 1 for implied bcc[0] */
355+
size = pdu_size + 4 + 1;
355356
conn->request_buf = kvmalloc(size, GFP_KERNEL);
356357
if (!conn->request_buf)
357358
break;

0 commit comments

Comments
 (0)