Skip to content

Commit 438a35e

Browse files
Kemeng Shitytso
authored andcommitted
ext4: remove unused parameter ngroup in ext4_mb_choose_next_group_*()
Remove unused parameter ngroup in ext4_mb_choose_next_group_*(). Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: Jan Kara <jack@suse.cz> Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com> Link: https://lore.kernel.org/r/20240105092102.496631-3-shikemeng@huaweicloud.com Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent 133de5a commit 438a35e

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

fs/ext4/mballoc.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -870,7 +870,7 @@ mb_update_avg_fragment_size(struct super_block *sb, struct ext4_group_info *grp)
870870
* cr level needs an update.
871871
*/
872872
static void ext4_mb_choose_next_group_p2_aligned(struct ext4_allocation_context *ac,
873-
enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
873+
enum criteria *new_cr, ext4_group_t *group)
874874
{
875875
struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
876876
struct ext4_group_info *iter;
@@ -944,7 +944,7 @@ ext4_mb_find_good_group_avg_frag_lists(struct ext4_allocation_context *ac, int o
944944
* order. Updates *new_cr if cr level needs an update.
945945
*/
946946
static void ext4_mb_choose_next_group_goal_fast(struct ext4_allocation_context *ac,
947-
enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
947+
enum criteria *new_cr, ext4_group_t *group)
948948
{
949949
struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
950950
struct ext4_group_info *grp = NULL;
@@ -989,7 +989,7 @@ static void ext4_mb_choose_next_group_goal_fast(struct ext4_allocation_context *
989989
* much and fall to CR_GOAL_LEN_SLOW in that case.
990990
*/
991991
static void ext4_mb_choose_next_group_best_avail(struct ext4_allocation_context *ac,
992-
enum criteria *new_cr, ext4_group_t *group, ext4_group_t ngroups)
992+
enum criteria *new_cr, ext4_group_t *group)
993993
{
994994
struct ext4_sb_info *sbi = EXT4_SB(ac->ac_sb);
995995
struct ext4_group_info *grp = NULL;
@@ -1124,11 +1124,11 @@ static void ext4_mb_choose_next_group(struct ext4_allocation_context *ac,
11241124
}
11251125

11261126
if (*new_cr == CR_POWER2_ALIGNED) {
1127-
ext4_mb_choose_next_group_p2_aligned(ac, new_cr, group, ngroups);
1127+
ext4_mb_choose_next_group_p2_aligned(ac, new_cr, group);
11281128
} else if (*new_cr == CR_GOAL_LEN_FAST) {
1129-
ext4_mb_choose_next_group_goal_fast(ac, new_cr, group, ngroups);
1129+
ext4_mb_choose_next_group_goal_fast(ac, new_cr, group);
11301130
} else if (*new_cr == CR_BEST_AVAIL_LEN) {
1131-
ext4_mb_choose_next_group_best_avail(ac, new_cr, group, ngroups);
1131+
ext4_mb_choose_next_group_best_avail(ac, new_cr, group);
11321132
} else {
11331133
/*
11341134
* TODO: For CR=2, we can arrange groups in an rb tree sorted by

0 commit comments

Comments
 (0)