Skip to content

Commit 41c721f

Browse files
leitaobroonie
authored andcommitted
spi: tegra210-quad: use WARN_ON_ONCE instead of WARN_ON for timeouts
Some machines with tegra_qspi_combined_seq_xfer hardware issues generate excessive kernel warnings, severely polluting the logs: dmesg | grep -i "WARNING:.*tegra_qspi_transfer_one_message" | wc -l 94451 This patch replaces WARN_ON with WARN_ON_ONCE for timeout conditions to reduce log spam. The subsequent error message still prints on each occurrence, providing sufficient information about the failure, while the stack trace is only needed once for debugging purposes. Signed-off-by: Breno Leitao <leitao@debian.org> Link: https://patch.msgid.link/20250401-tegra-v2-1-126c293ec047@debian.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 36ff6c3 commit 41c721f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/spi/spi-tegra210-quad.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1117,7 +1117,7 @@ static int tegra_qspi_combined_seq_xfer(struct tegra_qspi *tqspi,
11171117
(&tqspi->xfer_completion,
11181118
QSPI_DMA_TIMEOUT);
11191119

1120-
if (WARN_ON(ret == 0)) {
1120+
if (WARN_ON_ONCE(ret == 0)) {
11211121
dev_err(tqspi->dev, "QSPI Transfer failed with timeout: %d\n",
11221122
ret);
11231123
if (tqspi->is_curr_dma_xfer &&

0 commit comments

Comments
 (0)