Skip to content

Commit 41a1e97

Browse files
author
Peter Zijlstra
committed
x86/mm: Convert unreachable() to BUG()
Commit 2190966 ("x86: Convert unreachable() to BUG()") missed one. And after commit 06e2474 ("objtool: Remove annotate_{,un}reachable()") the invalid use of unreachable() (rightfully) triggers warnings: vmlinux.o: warning: objtool: page_fault_oops() falls through to next function is_prefetch() Fixes: 2190966 ("x86: Convert unreachable() to BUG()") Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Link: https://lkml.kernel.org/r/20241216093215.GD12338@noisy.programming.kicks-ass.net
1 parent c3cb6c1 commit 41a1e97

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

arch/x86/mm/fault.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,7 @@ page_fault_oops(struct pt_regs *regs, unsigned long error_code,
678678
ASM_CALL_ARG3,
679679
, [arg1] "r" (regs), [arg2] "r" (address), [arg3] "r" (&info));
680680

681-
unreachable();
681+
BUG();
682682
}
683683
#endif
684684

0 commit comments

Comments
 (0)