Skip to content

Commit 40863cb

Browse files
mikechristiemartinkpetersen
authored andcommitted
scsi: target: iblock: Quiet bool conversion warning with pr_preempt use
We want to pass in true for pr_preempt's argument if we are doing a PRO_PREEMPT_AND_ABORT, so just test sa against PRO_PREEMPT_AND_ABORT, and pass the result directly to pr_preempt. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202306221655.Kwtqi1gI-lkp@intel.com/ Signed-off-by: Mike Christie <michael.christie@oracle.com> Link: https://lore.kernel.org/r/20230623161136.6270-1-michael.christie@oracle.com Reviewed-by: Maurizio Lombardi <mlombard@redhat.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 9b7c13b commit 40863cb

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/target/target_core_iblock.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -889,7 +889,7 @@ static sense_reason_t iblock_execute_pr_out(struct se_cmd *cmd, u8 sa, u64 key,
889889

890890
ret = ops->pr_preempt(bdev, key, sa_key,
891891
scsi_pr_type_to_block(type),
892-
sa == PRO_PREEMPT ? false : true);
892+
sa == PRO_PREEMPT_AND_ABORT);
893893
break;
894894
case PRO_RELEASE:
895895
if (!ops->pr_clear) {

0 commit comments

Comments
 (0)