Skip to content

Commit 404b739

Browse files
Umang Jaingregkh
authored andcommitted
staging: vchiq_arm: Use devm_kzalloc() for vchiq_arm_state allocation
The struct vchiq_arm_state 'platform_state' is currently allocated dynamically using kzalloc(). Unfortunately, it is never freed and is subjected to memory leaks in the error handling paths of the probe() function. To address the issue, use device resource management helper devm_kzalloc(), to ensure cleanup after its allocation. Fixes: 71bad7f ("staging: add bcm2708 vchiq driver") Cc: stable@vger.kernel.org Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/20241016130225.61024-2-umang.jain@ideasonboard.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 8cf0b93 commit 404b739

File tree

1 file changed

+1
-1
lines changed
  • drivers/staging/vc04_services/interface/vchiq_arm

1 file changed

+1
-1
lines changed

drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -593,7 +593,7 @@ vchiq_platform_init_state(struct vchiq_state *state)
593593
{
594594
struct vchiq_arm_state *platform_state;
595595

596-
platform_state = kzalloc(sizeof(*platform_state), GFP_KERNEL);
596+
platform_state = devm_kzalloc(state->dev, sizeof(*platform_state), GFP_KERNEL);
597597
if (!platform_state)
598598
return -ENOMEM;
599599

0 commit comments

Comments
 (0)