Skip to content

Commit 3fd43a2

Browse files
Uwe Kleine-Königbebarino
authored andcommitted
clk: tegra: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230312161512.2715500-27-u.kleine-koenig@pengutronix.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 0d65f74 commit 3fd43a2

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

drivers/clk/tegra/clk-tegra124-dfll-fcpu.c

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -612,7 +612,7 @@ static int tegra124_dfll_fcpu_probe(struct platform_device *pdev)
612612
return 0;
613613
}
614614

615-
static int tegra124_dfll_fcpu_remove(struct platform_device *pdev)
615+
static void tegra124_dfll_fcpu_remove(struct platform_device *pdev)
616616
{
617617
struct tegra_dfll_soc_data *soc;
618618

@@ -622,11 +622,9 @@ static int tegra124_dfll_fcpu_remove(struct platform_device *pdev)
622622
*/
623623
soc = tegra_dfll_unregister(pdev);
624624
if (IS_ERR(soc))
625-
return 0;
625+
return;
626626

627627
tegra_cvb_remove_opp_table(soc->dev, soc->cvb, soc->max_freq);
628-
629-
return 0;
630628
}
631629

632630
static const struct dev_pm_ops tegra124_dfll_pm_ops = {
@@ -637,7 +635,7 @@ static const struct dev_pm_ops tegra124_dfll_pm_ops = {
637635

638636
static struct platform_driver tegra124_dfll_fcpu_driver = {
639637
.probe = tegra124_dfll_fcpu_probe,
640-
.remove = tegra124_dfll_fcpu_remove,
638+
.remove_new = tegra124_dfll_fcpu_remove,
641639
.driver = {
642640
.name = "tegra124-dfll",
643641
.of_match_table = tegra124_dfll_fcpu_of_match,

0 commit comments

Comments
 (0)