Skip to content

Commit 3fae6d2

Browse files
committed
drm/atomic-helper: Change parameter name of drm_atomic_helper_commit_hw_done()
drm_atomic_helper_commit_hw_done() signals hardware completion of a given commit. It takes the drm_atomic_state being committed as a parameter. However, that parameter name is called (and documented) as old_state, which is pretty confusing. Let's rename that variable as state. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20250213-bridge-connector-v3-22-e71598f49c8f@kernel.org Signed-off-by: Maxime Ripard <mripard@kernel.org>
1 parent b756b0c commit 3fae6d2

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/gpu/drm/drm_atomic_helper.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2513,7 +2513,7 @@ EXPORT_SYMBOL(drm_atomic_helper_fake_vblank);
25132513

25142514
/**
25152515
* drm_atomic_helper_commit_hw_done - setup possible nonblocking commit
2516-
* @old_state: atomic state object with old state structures
2516+
* @state: atomic state object being committed
25172517
*
25182518
* This function is used to signal completion of the hardware commit step. After
25192519
* this step the driver is not allowed to read or change any permanent software
@@ -2526,14 +2526,14 @@ EXPORT_SYMBOL(drm_atomic_helper_fake_vblank);
25262526
* This is part of the atomic helper support for nonblocking commits, see
25272527
* drm_atomic_helper_setup_commit() for an overview.
25282528
*/
2529-
void drm_atomic_helper_commit_hw_done(struct drm_atomic_state *old_state)
2529+
void drm_atomic_helper_commit_hw_done(struct drm_atomic_state *state)
25302530
{
25312531
struct drm_crtc *crtc;
25322532
struct drm_crtc_state *old_crtc_state, *new_crtc_state;
25332533
struct drm_crtc_commit *commit;
25342534
int i;
25352535

2536-
for_each_oldnew_crtc_in_state(old_state, crtc, old_crtc_state, new_crtc_state, i) {
2536+
for_each_oldnew_crtc_in_state(state, crtc, old_crtc_state, new_crtc_state, i) {
25372537
commit = new_crtc_state->commit;
25382538
if (!commit)
25392539
continue;
@@ -2553,9 +2553,9 @@ void drm_atomic_helper_commit_hw_done(struct drm_atomic_state *old_state)
25532553
complete_all(&commit->hw_done);
25542554
}
25552555

2556-
if (old_state->fake_commit) {
2557-
complete_all(&old_state->fake_commit->hw_done);
2558-
complete_all(&old_state->fake_commit->flip_done);
2556+
if (state->fake_commit) {
2557+
complete_all(&state->fake_commit->hw_done);
2558+
complete_all(&state->fake_commit->flip_done);
25592559
}
25602560
}
25612561
EXPORT_SYMBOL(drm_atomic_helper_commit_hw_done);

0 commit comments

Comments
 (0)