Skip to content

Commit 3ee7ecd

Browse files
jinpuwangrleon
authored andcommitted
RDMA/rtrs-srv: Do not unconditionally enable irq
When IO is completed, rtrs can be called in softirq context, unconditionally enabling irq could cause panic. To be on safe side, use spin_lock_irqsave and spin_unlock_irqrestore instread. Fixes: 9cb8374 ("RDMA/rtrs: server: main functionality") Signed-off-by: Jack Wang <jinpu.wang@ionos.com> Signed-off-by: Florian-Ewald Mueller <florian-ewald.mueller@ionos.com> Signed-off-by: Md Haris Iqbal <haris.iqbal@ionos.com> Signed-off-by: Grzegorz Prajsner <grzegorz.prajsner@ionos.com> Link: https://lore.kernel.org/r/20231120154146.920486-2-haris.iqbal@ionos.com Signed-off-by: Leon Romanovsky <leon@kernel.org>
1 parent b6f09b1 commit 3ee7ecd

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/infiniband/ulp/rtrs/rtrs-srv.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,8 +65,9 @@ static bool rtrs_srv_change_state(struct rtrs_srv_path *srv_path,
6565
{
6666
enum rtrs_srv_state old_state;
6767
bool changed = false;
68+
unsigned long flags;
6869

69-
spin_lock_irq(&srv_path->state_lock);
70+
spin_lock_irqsave(&srv_path->state_lock, flags);
7071
old_state = srv_path->state;
7172
switch (new_state) {
7273
case RTRS_SRV_CONNECTED:
@@ -87,7 +88,7 @@ static bool rtrs_srv_change_state(struct rtrs_srv_path *srv_path,
8788
}
8889
if (changed)
8990
srv_path->state = new_state;
90-
spin_unlock_irq(&srv_path->state_lock);
91+
spin_unlock_irqrestore(&srv_path->state_lock, flags);
9192

9293
return changed;
9394
}

0 commit comments

Comments
 (0)