Skip to content

Commit 3e9ec97

Browse files
Uwe Kleine-Könighdeller
authored andcommitted
fbdev: omapfb/tpd12s015: Don't put .remove() in .exit.text and drop suppress_bind_attrs
On today's platforms the memory savings of putting the remove function in .exit isn't that relevant any more. It only matters for built-in drivers and typically saves a few 100k. The downside is that the driver cannot be unbound at runtime which is ancient and also slightly complicates testing. Also it requires to mark the driver struct with __refdata which is needed to suppress a (W=1) modpost warning: WARNING: modpost: drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015: section mismatch in reference: tpd_driver+0x4 (section: .data) -> tpd_remove (section: .exit.text) To simplify matters, move the remove callback to .text and drop .suppress_bind_attrs = true. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 20bcc28 commit 3e9ec97

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

drivers/video/fbdev/omap2/omapfb/displays/encoder-tpd12s015.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -283,7 +283,7 @@ static int tpd_probe(struct platform_device *pdev)
283283
return r;
284284
}
285285

286-
static int __exit tpd_remove(struct platform_device *pdev)
286+
static int tpd_remove(struct platform_device *pdev)
287287
{
288288
struct panel_drv_data *ddata = platform_get_drvdata(pdev);
289289
struct omap_dss_device *dssdev = &ddata->dssdev;
@@ -313,11 +313,10 @@ MODULE_DEVICE_TABLE(of, tpd_of_match);
313313

314314
static struct platform_driver tpd_driver = {
315315
.probe = tpd_probe,
316-
.remove = __exit_p(tpd_remove),
316+
.remove = tpd_remove,
317317
.driver = {
318318
.name = "tpd12s015",
319319
.of_match_table = tpd_of_match,
320-
.suppress_bind_attrs = true,
321320
},
322321
};
323322

0 commit comments

Comments
 (0)