Skip to content

Commit 3e6ac85

Browse files
bijudasgregkh
authored andcommitted
usb: gadget: udc: renesas_usb3: Fix RZ/V2M {modprobe,bind} error
Currently {modprobe, bind} after {rmmod, unbind} results in probe failure. genirq: Flags mismatch irq 22. 00000004 (85070400.usb3drd) vs. 00000004 (85070400.usb3drd) renesas_usb3: probe of 85070000.usb3peri failed with error -16 The reason is, it is trying to register an interrupt handler for the same IRQ twice. The devm_request_irq() was called with the parent device. So the interrupt handler won't be unregistered when the usb3-peri device is unbound. Fix this issue by replacing "parent dev"->"dev" as the irq resource is managed by this driver. Fixes: 9cad72d ("usb: gadget: Add support for RZ/V2M USB3DRD driver") Cc: stable <stable@kernel.org> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Message-ID: <20230530161720.179927-1-biju.das.jz@bp.renesas.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 7b672f2 commit 3e6ac85

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

drivers/usb/gadget/udc/renesas_usb3.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2877,9 +2877,9 @@ static int renesas_usb3_probe(struct platform_device *pdev)
28772877
struct rzv2m_usb3drd *ddata = dev_get_drvdata(pdev->dev.parent);
28782878

28792879
usb3->drd_reg = ddata->reg;
2880-
ret = devm_request_irq(ddata->dev, ddata->drd_irq,
2880+
ret = devm_request_irq(&pdev->dev, ddata->drd_irq,
28812881
renesas_usb3_otg_irq, 0,
2882-
dev_name(ddata->dev), usb3);
2882+
dev_name(&pdev->dev), usb3);
28832883
if (ret < 0)
28842884
return ret;
28852885
}

0 commit comments

Comments
 (0)