writeback: fix call of incorrect macro

ProjectMutilation · axboe · commit 3e46c89c74f2 · 2023-04-28T10:41:32.000-06:00
the variable 'history' is of type u16, it may be an error that the hweight32 macro was used for it I guess macro hweight16 should be used Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 2a81490 ("writeback: implement foreign cgroup inode detection") Signed-off-by: Maxim Korotkov <korotkov.maxim.s@gmail.com> Reviewed-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20230119104443.3002-1-korotkov.maxim.s@gmail.com Signed-off-by: Jens Axboe <axboe@kernel.dk>
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
@@ -829,7 +829,7 @@ void wbc_detach_inode(struct writeback_control *wbc)
 		 * is okay.  The main goal is avoiding keeping an inode on
 		 * the wrong wb for an extended period of time.
 		 */
-		if (hweight32(history) > WB_FRN_HIST_THR_SLOTS)
+		if (hweight16(history) > WB_FRN_HIST_THR_SLOTS)
 			inode_switch_wbs(inode, max_id);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -829,7 +829,7 @@ void wbc_detach_inode(struct writeback_control *wbc)`
`829`	`829`	`* is okay. The main goal is avoiding keeping an inode on`
`830`	`830`	`* the wrong wb for an extended period of time.`
`831`	`831`	`*/`
`832`		`- if (hweight32(history) > WB_FRN_HIST_THR_SLOTS)`
	`832`	`+ if (hweight16(history) > WB_FRN_HIST_THR_SLOTS)`
`833`	`833`	`inode_switch_wbs(inode, max_id);`
`834`	`834`	`}`
`835`	`835`