Skip to content

Commit 3df7546

Browse files
Tetsuo HandaTetsuo Handa
authored andcommitted
tomoyo: don't emit warning in tomoyo_write_control()
syzbot is reporting too large allocation warning at tomoyo_write_control(), for one can write a very very long line without new line character. To fix this warning, I use __GFP_NOWARN rather than checking for KMALLOC_MAX_SIZE, for practically a valid line should be always shorter than 32KB where the "too small to fail" memory-allocation rule applies. One might try to write a valid line that is longer than 32KB, but such request will likely fail with -ENOMEM. Therefore, I feel that separately returning -EINVAL when a line is longer than KMALLOC_MAX_SIZE is redundant. There is no need to distinguish over-32KB and over-KMALLOC_MAX_SIZE. Reported-by: syzbot+7536f77535e5210a5c76@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=7536f77535e5210a5c76 Reported-by: Leo Stone <leocstone@gmail.com> Closes: https://lkml.kernel.org/r/20241216021459.178759-2-leocstone@gmail.com Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
1 parent 78d4f34 commit 3df7546

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

security/tomoyo/common.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2665,7 +2665,7 @@ ssize_t tomoyo_write_control(struct tomoyo_io_buffer *head,
26652665

26662666
if (head->w.avail >= head->writebuf_size - 1) {
26672667
const int len = head->writebuf_size * 2;
2668-
char *cp = kzalloc(len, GFP_NOFS);
2668+
char *cp = kzalloc(len, GFP_NOFS | __GFP_NOWARN);
26692669

26702670
if (!cp) {
26712671
error = -ENOMEM;

0 commit comments

Comments
 (0)