Skip to content

Commit 3d7aa0c

Browse files
richardweinbergerChristoph Hellwig
authored andcommitted
nvmet: fix out-of-bounds access in nvmet_enable_port
When trying to enable a port that has no transport configured yet, nvmet_enable_port() uses NVMF_TRTYPE_MAX (255) to query the transports array, causing an out-of-bounds access: [ 106.058694] BUG: KASAN: global-out-of-bounds in nvmet_enable_port+0x42/0x1da [ 106.058719] Read of size 8 at addr ffffffff89dafa58 by task ln/632 [...] [ 106.076026] nvmet: transport type 255 not supported Since commit 200adac, NVMF_TRTYPE_MAX is the default state as configured by nvmet_ports_make(). Avoid this by checking for NVMF_TRTYPE_MAX before proceeding. Fixes: 200adac ("nvme: Add PCI transport type") Signed-off-by: Richard Weinberger <richard@nod.at> Reviewed-by: Sagi Grimberg <sagi@grimberg.me> Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
1 parent 81dd1fe commit 3d7aa0c

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/nvme/target/core.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,9 @@ int nvmet_enable_port(struct nvmet_port *port)
324324

325325
lockdep_assert_held(&nvmet_config_sem);
326326

327+
if (port->disc_addr.trtype == NVMF_TRTYPE_MAX)
328+
return -EINVAL;
329+
327330
ops = nvmet_transports[port->disc_addr.trtype];
328331
if (!ops) {
329332
up_write(&nvmet_config_sem);

0 commit comments

Comments
 (0)