Skip to content

Commit 3a767b4

Browse files
hkallweitdavem330
authored andcommitted
r8169: remove not needed check in rtl_fw_write_firmware
This check can never be true for a firmware file with a correct format. Existing checks in rtl_fw_data_ok() are sufficient, no problems with invalid firmware files are known. Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 30c9020 commit 3a767b4

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/net/ethernet/realtek/r8169_firmware.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -151,9 +151,6 @@ void rtl_fw_write_firmware(struct rtl8169_private *tp, struct rtl_fw *rtl_fw)
151151
u32 regno = (action & 0x0fff0000) >> 16;
152152
enum rtl_fw_opcode opcode = action >> 28;
153153

154-
if (!action)
155-
break;
156-
157154
switch (opcode) {
158155
case PHY_READ:
159156
predata = fw_read(tp, regno);

0 commit comments

Comments
 (0)