Skip to content

Commit 39b1997

Browse files
bea-armctmarinas
authored andcommitted
arm64: Update AMU-based freq scale factor on entering idle
Now that the frequency scale factor has been activated for retrieving current frequency on a given CPU, trigger its update upon entering idle. This will, to an extent, allow querying last known frequency in a non-invasive way. It will also improve the frequency scale factor accuracy when a CPU entering idle did not receive a tick for a while. As a consequence, for idle cores, the reported frequency will be the last one observed before entering the idle state. Suggested-by: Vanshidhar Konda <vanshikonda@os.amperecomputing.com> Signed-off-by: Beata Michalska <beata.michalska@arm.com> Reviewed-by: Prasanna Kumar T S M <ptsm@linux.microsoft.com> Reviewed-by: Sumit Gupta <sumitg@nvidia.com> Link: https://lore.kernel.org/r/20250131162439.3843071-5-beata.michalska@arm.com Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
1 parent 16d1e27 commit 39b1997

File tree

1 file changed

+13
-0
lines changed

1 file changed

+13
-0
lines changed

arch/arm64/kernel/topology.c

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -213,6 +213,19 @@ static __always_inline bool amu_fie_cpu_supported(unsigned int cpu)
213213
cpumask_test_cpu(cpu, amu_fie_cpus);
214214
}
215215

216+
void arch_cpu_idle_enter(void)
217+
{
218+
unsigned int cpu = smp_processor_id();
219+
220+
if (!amu_fie_cpu_supported(cpu))
221+
return;
222+
223+
/* Kick in AMU update but only if one has not happened already */
224+
if (housekeeping_cpu(cpu, HK_TYPE_TICK) &&
225+
time_is_before_jiffies(per_cpu(cpu_amu_samples.last_scale_update, cpu)))
226+
amu_scale_freq_tick();
227+
}
228+
216229
#define AMU_SAMPLE_EXP_MS 20
217230

218231
int arch_freq_get_on_cpu(int cpu)

0 commit comments

Comments
 (0)