scsi: fnic: unlock on error path in fnic_queuecommand()

Dan Carpenter · martinkpetersen · commit 38945c2b006b · 2024-01-11T21:35:28.000-05:00
Call spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags) before returning. Fixes: c81df08 ("scsi: fnic: Add support for multiqueue (MQ) in fnic driver") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/5360fa20-74bc-4c22-a78e-ea8b18c5410d@moroto.mountain Reviewed-by: Karan Tilak Kumar <kartilak@cisco.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
diff --git a/drivers/scsi/fnic/fnic_scsi.c b/drivers/scsi/fnic/fnic_scsi.c
@@ -546,6 +546,7 @@ int fnic_queuecommand(struct Scsi_Host *shost, struct scsi_cmnd *sc)
 	if (fnic->sw_copy_wq[hwq].io_req_table[blk_mq_unique_tag_to_tag(mqtag)] != NULL) {
 		WARN(1, "fnic<%d>: %s: hwq: %d tag 0x%x already exists\n",
 				fnic->fnic_num, __func__, hwq, blk_mq_unique_tag_to_tag(mqtag));
+		spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags);
 		return SCSI_MLQUEUE_HOST_BUSY;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -546,6 +546,7 @@ int fnic_queuecommand(struct Scsi_Host shost, struct scsi_cmnd sc)`
`546`	`546`	`if (fnic->sw_copy_wq[hwq].io_req_table[blk_mq_unique_tag_to_tag(mqtag)] != NULL) {`
`547`	`547`	`WARN(1, "fnic<%d>: %s: hwq: %d tag 0x%x already exists\n",`
`548`	`548`	`fnic->fnic_num, __func__, hwq, blk_mq_unique_tag_to_tag(mqtag));`
	`549`	`+ spin_unlock_irqrestore(&fnic->wq_copy_lock[hwq], flags);`
`549`	`550`	`return SCSI_MLQUEUE_HOST_BUSY;`
`550`	`551`	`}`
`551`	`552`