fs/proc/task_mmu: fix pagemap flags with PMD THP entries on 32bit

davidhildenbrand · akpm00 · commit 3754137d263f · 2024-12-30T17:59:08.000-08:00
Entries (including flags) are u64, even on 32bit. So right now we are cutting of the flags on 32bit. This way, for example the cow selftest complains about: # ./cow ... Bail Out! read and ioctl return unmatched results for populated: 0 1 Link: https://lkml.kernel.org/r/20241217195000.1734039-1-david@redhat.com Fixes: 2c1f057 ("fs/proc/task_mmu: properly detect PM_MMAP_EXCLUSIVE per page of PMD-mapped THPs") Signed-off-by: David Hildenbrand <david@redhat.com> Cc: Oscar Salvador <osalvador@suse.de> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
@@ -1810,7 +1810,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,
 		}
 
 		for (; addr != end; addr += PAGE_SIZE, idx++) {
-			unsigned long cur_flags = flags;
+			u64 cur_flags = flags;
 			pagemap_entry_t pme;
 
 			if (folio && (flags & PM_PRESENT) &&

Original file line number	Diff line number	Diff line change
`@@ -1810,7 +1810,7 @@ static int pagemap_pmd_range(pmd_t *pmdp, unsigned long addr, unsigned long end,`
`1810`	`1810`	`}`
`1811`	`1811`
`1812`	`1812`	`for (; addr != end; addr += PAGE_SIZE, idx++) {`
`1813`		`- unsigned long cur_flags = flags;`
	`1813`	`+ u64 cur_flags = flags;`
`1814`	`1814`	`pagemap_entry_t pme;`
`1815`	`1815`
`1816`	`1816`	`if (folio && (flags & PM_PRESENT) &&`