Skip to content

Commit 361dde3

Browse files
larsclausenbebarino
authored andcommitted
clk: si5351: Use managed of_clk_add_hw_provider()
Use the managed `devm_of_clk_add_hw_provider()` instead of `of_clk_add_hw_provider()`. This makes sure the provider gets automatically removed on unbind and allows to completely eliminate the drivers `remove()` callback. Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> Link: https://lore.kernel.org/r/20230410014502.27929-10-lars@metafoo.de Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent bda7339 commit 361dde3

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

drivers/clk/clk-si5351.c

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1641,8 +1641,8 @@ static int si5351_i2c_probe(struct i2c_client *client)
16411641
}
16421642
}
16431643

1644-
ret = of_clk_add_hw_provider(client->dev.of_node, si53351_of_clk_get,
1645-
drvdata);
1644+
ret = devm_of_clk_add_hw_provider(&client->dev, si53351_of_clk_get,
1645+
drvdata);
16461646
if (ret) {
16471647
dev_err(&client->dev, "unable to add clk provider\n");
16481648
return ret;
@@ -1651,18 +1651,12 @@ static int si5351_i2c_probe(struct i2c_client *client)
16511651
return 0;
16521652
}
16531653

1654-
static void si5351_i2c_remove(struct i2c_client *client)
1655-
{
1656-
of_clk_del_provider(client->dev.of_node);
1657-
}
1658-
16591654
static struct i2c_driver si5351_driver = {
16601655
.driver = {
16611656
.name = "si5351",
16621657
.of_match_table = of_match_ptr(si5351_dt_ids),
16631658
},
16641659
.probe_new = si5351_i2c_probe,
1665-
.remove = si5351_i2c_remove,
16661660
.id_table = si5351_i2c_ids,
16671661
};
16681662
module_i2c_driver(si5351_driver);

0 commit comments

Comments
 (0)