Skip to content

Commit 34c21f9

Browse files
jhovoldvinodkoul
authored andcommitted
phy: qcom: qmp-usbc: fix NULL-deref on runtime suspend
Commit 413db06 ("phy: qcom-qmp-usb: clean up probe initialisation") removed most users of the platform device driver data from the qcom-qmp-usb driver, but mistakenly also removed the initialisation despite the data still being used in the runtime PM callbacks. This bug was later reproduced when the driver was copied to create the qmp-usbc driver. Restore the driver data initialisation at probe to avoid a NULL-pointer dereference on runtime suspend. Apparently no one uses runtime PM, which currently needs to be enabled manually through sysfs, with these drivers. Fixes: 1928157 ("phy: qcom: qmp-usb: split USB-C PHY driver") Cc: stable@vger.kernel.org # 6.9 Signed-off-by: Johan Hovold <johan+linaro@kernel.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Link: https://lore.kernel.org/r/20240911115253.10920-4-johan+linaro@kernel.org Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 2924013 commit 34c21f9

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/phy/qualcomm/phy-qcom-qmp-usbc.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1050,6 +1050,7 @@ static int qmp_usbc_probe(struct platform_device *pdev)
10501050
return -ENOMEM;
10511051

10521052
qmp->dev = dev;
1053+
dev_set_drvdata(dev, qmp);
10531054

10541055
qmp->orientation = TYPEC_ORIENTATION_NORMAL;
10551056

0 commit comments

Comments
 (0)