riscv: Fix missing __free_pages() in check_vector_unaligned_access()

Alexandre Ghiti · Alexandre Ghiti · commit 33981b1c4e49 · 2025-03-18T13:37:56.000Z
The locally allocated pages are never freed up, so add the corresponding __free_pages(). Fixes: e7c9d66 ("RISC-V: Report vector unaligned access speed hwprobe") Link: https://lore.kernel.org/r/20250228090613.345309-1-alexghiti@rivosinc.com Signed-off-by: Alexandre Ghiti <alexghiti@rivosinc.com>
diff --git a/arch/riscv/kernel/unaligned_access_speed.c b/arch/riscv/kernel/unaligned_access_speed.c
@@ -349,7 +349,7 @@ static void check_vector_unaligned_access(struct work_struct *work __always_unus
 		pr_warn("cpu%d: rdtime lacks granularity needed to measure unaligned vector access speed\n",
 			cpu);
 
-		return;
+		goto free;
 	}
 
 	if (word_cycles < byte_cycles)
@@ -363,6 +363,9 @@ static void check_vector_unaligned_access(struct work_struct *work __always_unus
 		(speed ==  RISCV_HWPROBE_MISALIGNED_VECTOR_FAST) ? "fast" : "slow");
 
 	per_cpu(vector_misaligned_access, cpu) = speed;
+
+free:
+	__free_pages(page, MISALIGNED_BUFFER_ORDER);
 }
 
 static int riscv_online_cpu_vec(unsigned int cpu)

Original file line number	Diff line number	Diff line change
`@@ -349,7 +349,7 @@ static void check_vector_unaligned_access(struct work_struct *work __always_unus`
`349`	`349`	`pr_warn("cpu%d: rdtime lacks granularity needed to measure unaligned vector access speed\n",`
`350`	`350`	`cpu);`
`351`	`351`
`352`		`- return;`
	`352`	`+ goto free;`
`353`	`353`	`}`
`354`	`354`
`355`	`355`	`if (word_cycles < byte_cycles)`
`@@ -363,6 +363,9 @@ static void check_vector_unaligned_access(struct work_struct *work __always_unus`
`363`	`363`	`(speed == RISCV_HWPROBE_MISALIGNED_VECTOR_FAST) ? "fast" : "slow");`
`364`	`364`
`365`	`365`	`per_cpu(vector_misaligned_access, cpu) = speed;`
	`366`	`+`
	`367`	`+free:`
	`368`	`+ __free_pages(page, MISALIGNED_BUFFER_ORDER);`
`366`	`369`	`}`
`367`	`370`
`368`	`371`	`static int riscv_online_cpu_vec(unsigned int cpu)`