Skip to content

Commit 3150b70

Browse files
committed
ASoC: meson: g12a-toacodec: Validate written enum values
When writing to an enum we need to verify that the value written is valid for the enumeration, the helper function snd_soc_item_enum_to_val() doesn't do it since it needs to return an unsigned (and in any case we'd need to check the return value). Fixes: af2618a ("ASoC: meson: g12a: add internal DAC glue driver") Signed-off-by: Mark Brown <broonie@kernel.org> Link: https://lore.kernel.org/r/20240103-meson-enum-val-v1-1-424af7a8fb91@kernel.org Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 38744c3 commit 3150b70

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

sound/soc/meson/g12a-toacodec.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,9 @@ static int g12a_toacodec_mux_put_enum(struct snd_kcontrol *kcontrol,
7171
struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;
7272
unsigned int mux, reg;
7373

74+
if (ucontrol->value.enumerated.item[0] >= e->items)
75+
return -EINVAL;
76+
7477
mux = snd_soc_enum_item_to_val(e, ucontrol->value.enumerated.item[0]);
7578
regmap_field_read(priv->field_dat_sel, &reg);
7679

0 commit comments

Comments
 (0)