Skip to content

Commit 306d40a

Browse files
compudjrostedt
authored andcommitted
tracing: Move it_func[0] comment to the relevant context
When introducing __DO_TRACE_CALL(), the iteration over it_func moved from __DO_TRACE() to __tracepoint_iter_##_name(), but the comment relevant for this iterator was left in its original location. Move the comment to the relevant context. Fixes: d25e37d ("tracepoint: Optimize using static_call()") Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Michael Jeanson <mjeanson@efficios.com> Cc: Masami Hiramatsu <mhiramat@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Alexei Starovoitov <ast@kernel.org> Cc: Yonghong Song <yhs@fb.com> Cc: Paul E. McKenney <paulmck@kernel.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Arnaldo Carvalho de Melo <acme@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Andrii Nakryiko <andrii.nakryiko@gmail.com> Cc: bpf@vger.kernel.org Cc: Joel Fernandes <joel@joelfernandes.org> Cc: Jordan Rife <jrife@google.com> Link: https://lore.kernel.org/20241123153031.2884933-2-mathieu.desnoyers@efficios.com Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 0172afe commit 306d40a

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

include/linux/tracepoint.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -210,9 +210,6 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p)
210210
#endif /* CONFIG_HAVE_STATIC_CALL */
211211

212212
/*
213-
* it_func[0] is never NULL because there is at least one element in the array
214-
* when the array itself is non NULL.
215-
*
216213
* With @syscall=0, the tracepoint callback array dereference is
217214
* protected by disabling preemption.
218215
* With @syscall=1, the tracepoint callback array dereference is
@@ -316,6 +313,9 @@ static inline struct tracepoint *tracepoint_ptr_deref(tracepoint_ptr_t *p)
316313
* We have no guarantee that gcc and the linker won't up-align the tracepoint
317314
* structures, so we create an array of pointers that will be used for iteration
318315
* on the tracepoints.
316+
*
317+
* it_func[0] is never NULL because there is at least one element in the array
318+
* when the array itself is non NULL.
319319
*/
320320
#define __DEFINE_TRACE_EXT(_name, _ext, proto, args) \
321321
static const char __tpstrtab_##_name[] \

0 commit comments

Comments
 (0)