Skip to content

Commit 3041808

Browse files
hygonitehcaster
authored andcommitted
mm/slab_common: move generic bulk alloc/free functions to SLOB
Now that only SLOB use __kmem_cache_{alloc,free}_bulk(), move them to SLOB. No functional change intended. Signed-off-by: Hyeonggon Yoo <42.hyeyoo@gmail.com> Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
1 parent 2055e67 commit 3041808

File tree

3 files changed

+21
-40
lines changed

3 files changed

+21
-40
lines changed

mm/slab.h

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -380,15 +380,6 @@ void slabinfo_show_stats(struct seq_file *m, struct kmem_cache *s);
380380
ssize_t slabinfo_write(struct file *file, const char __user *buffer,
381381
size_t count, loff_t *ppos);
382382

383-
/*
384-
* Generic implementation of bulk operations
385-
* These are useful for situations in which the allocator cannot
386-
* perform optimizations. In that case segments of the object listed
387-
* may be allocated or freed using these operations.
388-
*/
389-
void __kmem_cache_free_bulk(struct kmem_cache *, size_t, void **);
390-
int __kmem_cache_alloc_bulk(struct kmem_cache *, gfp_t, size_t, void **);
391-
392383
static inline enum node_stat_item cache_vmstat_idx(struct kmem_cache *s)
393384
{
394385
return (s->flags & SLAB_RECLAIM_ACCOUNT) ?

mm/slab_common.c

Lines changed: 0 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -104,33 +104,6 @@ static inline int kmem_cache_sanity_check(const char *name, unsigned int size)
104104
}
105105
#endif
106106

107-
void __kmem_cache_free_bulk(struct kmem_cache *s, size_t nr, void **p)
108-
{
109-
size_t i;
110-
111-
for (i = 0; i < nr; i++) {
112-
if (s)
113-
kmem_cache_free(s, p[i]);
114-
else
115-
kfree(p[i]);
116-
}
117-
}
118-
119-
int __kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t nr,
120-
void **p)
121-
{
122-
size_t i;
123-
124-
for (i = 0; i < nr; i++) {
125-
void *x = p[i] = kmem_cache_alloc(s, flags);
126-
if (!x) {
127-
__kmem_cache_free_bulk(s, i, p);
128-
return 0;
129-
}
130-
}
131-
return i;
132-
}
133-
134107
/*
135108
* Figure out what the alignment of the objects will be given a set of
136109
* flags, a user specified alignment and the size of the objects.

mm/slob.c

Lines changed: 21 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -692,16 +692,33 @@ void kmem_cache_free(struct kmem_cache *c, void *b)
692692
}
693693
EXPORT_SYMBOL(kmem_cache_free);
694694

695-
void kmem_cache_free_bulk(struct kmem_cache *s, size_t size, void **p)
695+
void kmem_cache_free_bulk(struct kmem_cache *s, size_t nr, void **p)
696696
{
697-
__kmem_cache_free_bulk(s, size, p);
697+
size_t i;
698+
699+
for (i = 0; i < nr; i++) {
700+
if (s)
701+
kmem_cache_free(s, p[i]);
702+
else
703+
kfree(p[i]);
704+
}
698705
}
699706
EXPORT_SYMBOL(kmem_cache_free_bulk);
700707

701-
int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t size,
708+
int kmem_cache_alloc_bulk(struct kmem_cache *s, gfp_t flags, size_t nr,
702709
void **p)
703710
{
704-
return __kmem_cache_alloc_bulk(s, flags, size, p);
711+
size_t i;
712+
713+
for (i = 0; i < nr; i++) {
714+
void *x = p[i] = kmem_cache_alloc(s, flags);
715+
716+
if (!x) {
717+
kmem_cache_free_bulk(s, i, p);
718+
return 0;
719+
}
720+
}
721+
return i;
705722
}
706723
EXPORT_SYMBOL(kmem_cache_alloc_bulk);
707724

0 commit comments

Comments
 (0)