Skip to content

Commit 2e92295

Browse files
gShahrjic23
authored andcommitted
staging: iio: adc: ad7816: Correct conditional logic for store mode
The mode setting logic in ad7816_store_mode was reversed due to incorrect handling of the strcmp return value. strcmp returns 0 on match, so the `if (strcmp(buf, "full"))` block executed when the input was not "full". This resulted in "full" setting the mode to AD7816_PD (power-down) and other inputs setting it to AD7816_FULL. Fix this by checking it against 0 to correctly check for "full" and "power-down", mapping them to AD7816_FULL and AD7816_PD respectively. Fixes: 7924425 ("staging: iio: adc: new driver for AD7816 devices") Cc: stable@vger.kernel.org Signed-off-by: Gabriel Shahrouzi <gshahrouzi@gmail.com> Acked-by: Nuno Sá <nuno.sa@analog.com> Link: https://lore.kernel.org/stable/20250414152920.467505-1-gshahrouzi%40gmail.com Link: https://patch.msgid.link/20250414154050.469482-1-gshahrouzi@gmail.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent 52d3498 commit 2e92295

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/staging/iio/adc/ad7816.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ static ssize_t ad7816_store_mode(struct device *dev,
136136
struct iio_dev *indio_dev = dev_to_iio_dev(dev);
137137
struct ad7816_chip_info *chip = iio_priv(indio_dev);
138138

139-
if (strcmp(buf, "full")) {
139+
if (strcmp(buf, "full") == 0) {
140140
gpiod_set_value(chip->rdwr_pin, 1);
141141
chip->mode = AD7816_FULL;
142142
} else {

0 commit comments

Comments
 (0)