Skip to content

Commit 2e245bc

Browse files
Daire McNamaraLorenzo Pieralisi
authored andcommitted
PCI: microchip: Enable building driver as a module
Enable building driver as a module. The expected use case is the driver is built as a module, is installed when needed, and cannot be removed once installed since it is not possible to clean-up the irq_chip data structures on removal, as described in: https://lore.kernel.org/linux-pci/87y1wgbah8.wl-maz@kernel.org/ The driver has .suppress_bind_attrs set to true for the same reasons (ie prevent unbinding, that would leave the kernel with stale IRQ configuration that cannot be cleaned up). Link: https://lore.kernel.org/linux-pci/87y1wgbah8.wl-maz@kernel.org/ Link: https://lore.kernel.org/r/20230728131401.1615724-3-daire.mcnamara@microchip.com Suggested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com> Signed-off-by: Lorenzo Pieralisi <lpieralisi@kernel.org> Acked-by: Conor Dooley <conor.dooley@microchip.com>
1 parent 6d473a5 commit 2e245bc

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

drivers/pci/controller/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ config PCIE_MT7621
217217
This selects a driver for the MediaTek MT7621 PCIe Controller.
218218

219219
config PCIE_MICROCHIP_HOST
220-
bool "Microchip AXI PCIe controller"
220+
tristate "Microchip AXI PCIe controller"
221221
depends on PCI_MSI && OF
222222
select PCI_HOST_COMMON
223223
help

drivers/pci/controller/pcie-microchip-host.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1135,5 +1135,6 @@ static struct platform_driver mc_pcie_driver = {
11351135
};
11361136

11371137
builtin_platform_driver(mc_pcie_driver);
1138+
MODULE_LICENSE("GPL");
11381139
MODULE_DESCRIPTION("Microchip PCIe host controller driver");
11391140
MODULE_AUTHOR("Daire McNamara <daire.mcnamara@microchip.com>");

0 commit comments

Comments
 (0)