Skip to content

Commit 2d18b7e

Browse files
wensbebarino
authored andcommitted
clk: mediatek: Unregister clks in mtk_clk_simple_probe() error path
Until now the mediatek clk driver library did not have any way to unregister clks, and so all drivers did not do proper cleanup in their error paths. Now that the library does have APIs to unregister clks, use them in the error path of mtk_clk_simple_probe() to do proper cleanup. Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> Reviewed-by: Miles Chen <miles.chen@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20220208124034.414635-28-wenst@chromium.org Reviewed-by: Chun-Jie Chen <chun-jie.chen@mediatek.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>
1 parent 3c3ba2a commit 2d18b7e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

drivers/clk/mediatek/clk-mtk.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -439,12 +439,14 @@ int mtk_clk_simple_probe(struct platform_device *pdev)
439439

440440
r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
441441
if (r)
442-
goto free_data;
442+
goto unregister_clks;
443443

444444
platform_set_drvdata(pdev, clk_data);
445445

446446
return r;
447447

448+
unregister_clks:
449+
mtk_clk_unregister_gates(mcd->clks, mcd->num_clks, clk_data);
448450
free_data:
449451
mtk_free_clk_data(clk_data);
450452
return r;

0 commit comments

Comments
 (0)