Skip to content

Commit 2c234a2

Browse files
Darrick J. WongChandan Babu R
authored andcommitted
xfs: fix dqiterate thinko
For some unknown reason, when I converted the incore dquot objects to store the dquot id in host endian order, I removed the increment here. This causes the scan to stop after retrieving the root dquot, which severely limits the usefulness of the quota scrubber. Fix the lost increment, though it won't fix the problem that the quota iterator code filters out zeroed dquot records. Fixes: c51df73 ("xfs: stop using q_core.d_id in the quota code") Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> Reviewed-by: Dave Chinner <dchinner@redhat.com> Signed-off-by: Chandan Babu R <chandan.babu@oracle.com>
1 parent 220c8d5 commit 2c234a2

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/xfs/xfs_dquot.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1386,7 +1386,7 @@ xfs_qm_dqiterate(
13861386
return error;
13871387

13881388
error = iter_fn(dq, type, priv);
1389-
id = dq->q_id;
1389+
id = dq->q_id + 1;
13901390
xfs_qm_dqput(dq);
13911391
} while (error == 0 && id != 0);
13921392

0 commit comments

Comments
 (0)