drm/i915/dp: Fix passing the correct DPCD_REV for drm_dp_set_phy_test_pattern

almahallawy · jnikula · commit 2bd7a06a1208 · 2023-12-27T12:49:50.000+02:00
Using link_status to get DPCD_REV fails when disabling/defaulting phy pattern. Use intel_dp->dpcd to access DPCD_REV correctly. Fixes: 8cdf727 ("drm/i915/dp: Program vswing, pre-emphasis, test-pattern") Cc: Jani Nikula <jani.nikula@intel.com> Cc: Imre Deak <imre.deak@intel.com> Cc: Lee Shawn C <shawn.c.lee@intel.com> Signed-off-by: Khaled Almahallawy <khaled.almahallawy@intel.com> Signed-off-by: Jani Nikula <jani.nikula@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20231213211542.3585105-3-khaled.almahallawy@intel.com (cherry picked from commit 3ee302e)
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4496,7 +4496,7 @@ static void intel_dp_process_phy_request(struct intel_dp *intel_dp,
 			  intel_dp->train_set, crtc_state->lane_count);
 
 	drm_dp_set_phy_test_pattern(&intel_dp->aux, data,
-				    link_status[DP_DPCD_REV]);
+				    intel_dp->dpcd[DP_DPCD_REV]);
 }
 
 static u8 intel_dp_autotest_phy_pattern(struct intel_dp *intel_dp)

Original file line number	Diff line number	Diff line change
`@@ -4496,7 +4496,7 @@ static void intel_dp_process_phy_request(struct intel_dp *intel_dp,`
`4496`	`4496`	`intel_dp->train_set, crtc_state->lane_count);`
`4497`	`4497`
`4498`	`4498`	`drm_dp_set_phy_test_pattern(&intel_dp->aux, data,`
`4499`		`- link_status[DP_DPCD_REV]);`
	`4499`	`+ intel_dp->dpcd[DP_DPCD_REV]);`
`4500`	`4500`	`}`
`4501`	`4501`
`4502`	`4502`	`static u8 intel_dp_autotest_phy_pattern(struct intel_dp *intel_dp)`