Skip to content

Commit 2a96271

Browse files
vishniakoudtor
authored andcommitted
Input: document the units for resolution of size axes
Today, the resolution of size axes is not documented. As a result, it's not clear what the canonical interpretation of this value should be. On Android, there is a need to calculate the size of the touch ellipse in physical units (millimeters). After reviewing linux source, it turned out that most of the existing usages are already interpreting this value as "units/mm". This documentation will make it explicit. This will help device implementations with correctly following the linux specs, and will ensure that the devices will work on Android without needing further customized parameters for scaling of major/minor values. Signed-off-by: Siarhei Vishniakou <svv@google.com> Reviewed-by: Jeff LaBundy <jeff@labundy.com> Link: https://lore.kernel.org/r/20220520084514.3451193-1-svv@google.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
1 parent 3de93e6 commit 2a96271

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

include/uapi/linux/input.h

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -78,10 +78,13 @@ struct input_id {
7878
* Note that input core does not clamp reported values to the
7979
* [minimum, maximum] limits, such task is left to userspace.
8080
*
81-
* The default resolution for main axes (ABS_X, ABS_Y, ABS_Z)
82-
* is reported in units per millimeter (units/mm), resolution
83-
* for rotational axes (ABS_RX, ABS_RY, ABS_RZ) is reported
84-
* in units per radian.
81+
* The default resolution for main axes (ABS_X, ABS_Y, ABS_Z,
82+
* ABS_MT_POSITION_X, ABS_MT_POSITION_Y) is reported in units
83+
* per millimeter (units/mm), resolution for rotational axes
84+
* (ABS_RX, ABS_RY, ABS_RZ) is reported in units per radian.
85+
* The resolution for the size axes (ABS_MT_TOUCH_MAJOR,
86+
* ABS_MT_TOUCH_MINOR, ABS_MT_WIDTH_MAJOR, ABS_MT_WIDTH_MINOR)
87+
* is reported in units per millimeter (units/mm).
8588
* When INPUT_PROP_ACCELEROMETER is set the resolution changes.
8689
* The main axes (ABS_X, ABS_Y, ABS_Z) are then reported in
8790
* units per g (units/g) and in units per degree per second

0 commit comments

Comments
 (0)