Skip to content

Commit 2933d3c

Browse files
azeemshaikh38rostedt
authored andcommitted
tracing: Replace strlcpy with strscpy in trace/events/task.h
strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] KSPP#89 Link: https://lore.kernel.org/linux-trace-kernel/20230831194212.1529941-1-azeemshaikh38@gmail.com Cc: Masami Hiramatsu <mhiramat@kernel.org> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com> Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 3163f63 commit 2933d3c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/trace/events/task.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ TRACE_EVENT(task_rename,
4747
TP_fast_assign(
4848
__entry->pid = task->pid;
4949
memcpy(entry->oldcomm, task->comm, TASK_COMM_LEN);
50-
strlcpy(entry->newcomm, comm, TASK_COMM_LEN);
50+
strscpy(entry->newcomm, comm, TASK_COMM_LEN);
5151
__entry->oom_score_adj = task->signal->oom_score_adj;
5252
),
5353

0 commit comments

Comments
 (0)