Skip to content

Commit 288ff0d

Browse files
maurizio-lombardikeithbusch
authored andcommitted
nvme-pci: skip nvme_write_sq_db on empty rqlist
nvme_submit_cmds() should check the rqlist before calling nvme_write_sq_db(); if the list is empty, it must return immediately. Fixes: beadf00 ("nvme-pci: reverse request order in nvme_queue_rqs") Signed-off-by: Maurizio Lombardi <mlombard@redhat.com> Signed-off-by: Keith Busch <kbusch@kernel.org>
1 parent 32c9281 commit 288ff0d

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

drivers/nvme/host/pci.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -986,6 +986,9 @@ static void nvme_submit_cmds(struct nvme_queue *nvmeq, struct rq_list *rqlist)
986986
{
987987
struct request *req;
988988

989+
if (rq_list_empty(rqlist))
990+
return;
991+
989992
spin_lock(&nvmeq->sq_lock);
990993
while ((req = rq_list_pop(rqlist))) {
991994
struct nvme_iod *iod = blk_mq_rq_to_pdu(req);

0 commit comments

Comments
 (0)