Skip to content

Commit 28403c0

Browse files
author
Al Viro
committed
nfsd: kill stale comment about simple_fill_super() requirements
That went into the tree back in 2005; the comment used to be true for predecessor of simple_fill_super() that happened to live in nfsd; that one didn't take care to skip the array entries with NULL ->name, so it could not tolerate any gaps. That had been fixed in 2003 when nfsd_fill_super() had been abstracted into simple_fill_super(); if Neil's patch lived out of tree during that time, he probably replaced the name of function when rebasing it and didn't notice that restriction in question was no longer there. Acked-by: Chuck Lever <chuck.lever@oracle.com> Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
1 parent 743cde7 commit 28403c0

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

fs/nfsd/nfsctl.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,6 @@ enum {
4848
NFSD_MaxBlkSize,
4949
NFSD_MaxConnections,
5050
NFSD_Filecache,
51-
/*
52-
* The below MUST come last. Otherwise we leave a hole in nfsd_files[]
53-
* with !CONFIG_NFSD_V4 and simple_fill_super() goes oops
54-
*/
5551
#ifdef CONFIG_NFSD_V4
5652
NFSD_Leasetime,
5753
NFSD_Gracetime,

0 commit comments

Comments
 (0)