Skip to content

Commit 28330ce

Browse files
committed
OPP: debugfs: Fix warning around icc_get_name()
If the kernel isn't built with interconnect support, icc_get_name() returns NULL and we get following warning: drivers/opp/debugfs.c: In function 'bw_name_read': drivers/opp/debugfs.c:43:42: error: '%.62s' directive argument is null [-Werror=format-overflow=] i = scnprintf(buf, sizeof(buf), "%.62s\n", icc_get_name(path)); Fix it. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202402141313.81ltVF5g-lkp@intel.com/ Fixes: 0430b1d ("opp: Expose bandwidth information via debugfs") Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by: Dhruva Gole <d-gole@ti.com>
1 parent 992e883 commit 28330ce

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

drivers/opp/debugfs.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,12 @@ static ssize_t bw_name_read(struct file *fp, char __user *userbuf,
3737
size_t count, loff_t *ppos)
3838
{
3939
struct icc_path *path = fp->private_data;
40+
const char *name = icc_get_name(path);
4041
char buf[64];
41-
int i;
42+
int i = 0;
4243

43-
i = scnprintf(buf, sizeof(buf), "%.62s\n", icc_get_name(path));
44+
if (name)
45+
i = scnprintf(buf, sizeof(buf), "%.62s\n", name);
4446

4547
return simple_read_from_buffer(userbuf, count, ppos, buf, i);
4648
}

0 commit comments

Comments
 (0)