Skip to content

Commit 27d1a62

Browse files
andy-shevpavelmachek
authored andcommitted
leds: tca6507: Get rid of duplicate of_node assignment
GPIO library does copy the of_node from the parent device of the GPIO chip, there is no need to repeat this in the individual drivers. Remove assignment here. For the details one may look into the of_gpio_dev_init() implementation. Call graph: --> tca6507_probe_gpios() --> gpiochip_add_data() --> gpiochip_add_data_with_key() --> of_gpio_dev_init() Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Pavel Machek <pavel@ucw.cz>
1 parent b7f1ac9 commit 27d1a62

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/leds/leds-tca6507.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -641,9 +641,6 @@ static int tca6507_probe_gpios(struct device *dev,
641641
tca->gpio.direction_output = tca6507_gpio_direction_output;
642642
tca->gpio.set = tca6507_gpio_set_value;
643643
tca->gpio.parent = dev;
644-
#ifdef CONFIG_OF_GPIO
645-
tca->gpio.of_node = of_node_get(dev_of_node(dev));
646-
#endif
647644
err = gpiochip_add_data(&tca->gpio, tca);
648645
if (err) {
649646
tca->gpio.ngpio = 0;

0 commit comments

Comments
 (0)