Skip to content

Commit 26e8383

Browse files
Lakshmi-ygroeck
authored andcommitted
hwmon: (pmbus/ucd9000) Increase delay from 250 to 500us
Following the failure observed with a delay of 250us, experiments were conducted with various delays. It was found that a delay of 350us effectively mitigated the issue. To provide a more optimal solution while still allowing a margin for stability, the delay is being adjusted to 500us. Signed-off-by: Lakshmi Yadlapati <lakshmiy@us.ibm.com> Link: https://lore.kernel.org/r/20240507194603.1305750-1-lakshmiy@us.ibm.com Fixes: 8d655e6 ("hwmon: (ucd90320) Add minimum delay between bus accesses") Reviewed-by: Eddie James <eajames@linux.ibm.com> Cc: stable@vger.kernel.org Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent d02abd5 commit 26e8383

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/hwmon/pmbus/ucd9000.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,11 @@ struct ucd9000_debugfs_entry {
8080
* It has been observed that the UCD90320 randomly fails register access when
8181
* doing another access right on the back of a register write. To mitigate this
8282
* make sure that there is a minimum delay between a write access and the
83-
* following access. The 250us is based on experimental data. At a delay of
84-
* 200us the issue seems to go away. Add a bit of extra margin to allow for
83+
* following access. The 500 is based on experimental data. At a delay of
84+
* 350us the issue seems to go away. Add a bit of extra margin to allow for
8585
* system to system differences.
8686
*/
87-
#define UCD90320_WAIT_DELAY_US 250
87+
#define UCD90320_WAIT_DELAY_US 500
8888

8989
static inline void ucd90320_wait(const struct ucd9000_data *data)
9090
{

0 commit comments

Comments
 (0)