Skip to content

Commit 2598bd3

Browse files
committed
eventfs: Test for dentries array allocated in eventfs_release()
The dcache_dir_open_wrapper() could be called when a dynamic event is being deleted leaving a dentry with no children. In this case the dlist->dentries array will never be allocated. This needs to be checked for in eventfs_release(), otherwise it will trigger a NULL pointer dereference. Link: https://lore.kernel.org/linux-trace-kernel/20230930090106.1c3164e9@rorschach.local.home Cc: Mark Rutland <mark.rutland@arm.com> Acked-by: Masami Hiramatsu (Google) <mhiramat@kernel.org> Fixes: ef36b4f ("eventfs: Remember what dentries were created on dir open") Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
1 parent 2de9ee9 commit 2598bd3

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/tracefs/event_inode.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -421,7 +421,7 @@ static int eventfs_release(struct inode *inode, struct file *file)
421421
if (WARN_ON_ONCE(!dlist))
422422
return -EINVAL;
423423

424-
for (i = 0; dlist->dentries[i]; i++) {
424+
for (i = 0; dlist->dentries && dlist->dentries[i]; i++) {
425425
dput(dlist->dentries[i]);
426426
}
427427

0 commit comments

Comments
 (0)