Skip to content

Commit 23d04d8

Browse files
mu-mu-muIngo Molnar
authored andcommitted
sched/fair: Take the scheduling domain into account in select_idle_core()
When picking a CPU on task wakeup, select_idle_core() has to take into account the scheduling domain where the function looks for the CPU. This is because the "isolcpus" kernel command line option can remove CPUs from the domain to isolate them from other SMT siblings. This change replaces the set of CPUs allowed to run the task from p->cpus_ptr by the intersection of p->cpus_ptr and sched_domain_span(sd) which is stored in the 'cpus' argument provided by select_idle_cpu(). Fixes: 9fe1f12 ("sched/fair: Merge select_idle_core/cpu()") Signed-off-by: Keisuke Nishimura <keisuke.nishimura@inria.fr> Signed-off-by: Julia Lawall <julia.lawall@inria.fr> Signed-off-by: Ingo Molnar <mingo@kernel.org> Link: https://lore.kernel.org/r/20240110131707.437301-2-keisuke.nishimura@inria.fr
1 parent 8aeaffe commit 23d04d8

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/sched/fair.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7289,15 +7289,15 @@ static int select_idle_core(struct task_struct *p, int core, struct cpumask *cpu
72897289
if (!available_idle_cpu(cpu)) {
72907290
idle = false;
72917291
if (*idle_cpu == -1) {
7292-
if (sched_idle_cpu(cpu) && cpumask_test_cpu(cpu, p->cpus_ptr)) {
7292+
if (sched_idle_cpu(cpu) && cpumask_test_cpu(cpu, cpus)) {
72937293
*idle_cpu = cpu;
72947294
break;
72957295
}
72967296
continue;
72977297
}
72987298
break;
72997299
}
7300-
if (*idle_cpu == -1 && cpumask_test_cpu(cpu, p->cpus_ptr))
7300+
if (*idle_cpu == -1 && cpumask_test_cpu(cpu, cpus))
73017301
*idle_cpu = cpu;
73027302
}
73037303

0 commit comments

Comments
 (0)