Skip to content

Commit 235f2b5

Browse files
dinghaoliumartinkpetersen
authored andcommitted
scsi: be2iscsi: Fix a memleak in beiscsi_init_wrb_handle()
When an error occurs in the for loop of beiscsi_init_wrb_handle(), we should free phwi_ctxt->be_wrbq before returning an error code to prevent potential memleak. Fixes: a7909b3 ("[SCSI] be2iscsi: Fix dynamic CID allocation Mechanism in driver") Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> Link: https://lore.kernel.org/r/20231123081941.24854-1-dinghao.liu@zju.edu.cn Reviewed-by: Mike Christie <michael.christie@oracle.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent b09d7f8 commit 235f2b5

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/scsi/be2iscsi/be_main.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2710,6 +2710,7 @@ static int beiscsi_init_wrb_handle(struct beiscsi_hba *phba)
27102710
kfree(pwrb_context->pwrb_handle_base);
27112711
kfree(pwrb_context->pwrb_handle_basestd);
27122712
}
2713+
kfree(phwi_ctxt->be_wrbq);
27132714
return -ENOMEM;
27142715
}
27152716

0 commit comments

Comments
 (0)